From: David Miller <davem@davemloft.net>
To: bhutchings@solarflare.com
Cc: scottjg@vmware.com, netdev@vger.kernel.org, pv-drivers@vmware.com
Subject: Re: [PATCH] vmxnet3: fix starving rx ring when alloc_skb fails
Date: Fri, 17 Jun 2011 12:09:00 -0400 (EDT) [thread overview]
Message-ID: <20110617.120900.550060204741705506.davem@davemloft.net> (raw)
In-Reply-To: <1308312860.11457.56.camel@localhost>
From: Ben Hutchings <bhutchings@solarflare.com>
Date: Fri, 17 Jun 2011 13:14:20 +0100
> But this means the driver drops received packets as soon as there is an
> allocation failure, rather than only if there are repeated failures. I
> don't see how that's preferable.
Because it decreases the possibility of RX ring starvation.
If you get one allocation failure during a NAPI poll run, and you're
proabably processing a set of packets, they are all going to fail.
next prev parent reply other threads:[~2011-06-17 16:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-16 22:02 [PATCH] vmxnet3: fix starving rx ring when alloc_skb fails Scott J. Goldman
2011-06-16 22:56 ` [Pv-drivers] " Bhavesh Davda
2011-06-17 4:16 ` David Miller
2011-06-17 4:40 ` Scott Goldman
2011-06-17 4:53 ` David Miller
2011-06-17 12:14 ` Ben Hutchings
2011-06-17 16:09 ` David Miller [this message]
2011-07-06 0:34 ` [PATCH] vmxnet3: fix starving rx ring whenoc_skb kb fails Shreyas Bhatewara
2011-07-06 1:40 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110617.120900.550060204741705506.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bhutchings@solarflare.com \
--cc=netdev@vger.kernel.org \
--cc=pv-drivers@vmware.com \
--cc=scottjg@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).