netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: carolyn.wyborny@intel.com
Cc: netdev@vger.kernel.org, bhutchings@solarflare.com
Subject: Re: [RFC 2/2] ethtool: Add support for DMA Coalescing feature config to ethtool.
Date: Fri, 17 Jun 2011 14:54:20 -0400 (EDT)	[thread overview]
Message-ID: <20110617.145420.866989290749857501.davem@davemloft.net> (raw)
In-Reply-To: <EDC0E76513226749BFBC9C3FB031318F016EEF8A6E@orsmsx508.amr.corp.intel.com>

From: "Wyborny, Carolyn" <carolyn.wyborny@intel.com>
Date: Fri, 17 Jun 2011 08:50:11 -0700

> I will add a fuller description of the feature in my updated patch.
> I thought the feature was more well known. Quick description is that
> it's a power saving feature that causes the adapter to coalesce its
> DMA writes at low traffic times to save power on the platform by
> reducing wakeups.  The parameter is intended as a simple u32 value,
> not just an on or off, but also to allow a variety of configuration
> by adapter vendors, with validation of the input on the driver side.
> Since I left out the implementation in my patch, this wasn't clear.
> I will also fix this in my next submission.

The value cannot have adapter specific meaning, you must define it
precisely and in a generic manner, such that the user can specify the
same setting across different card types.

  reply	other threads:[~2011-06-17 18:54 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-14 17:13 [RFC 2/2] ethtool: Add support for DMA Coalescing feature config to ethtool Carolyn Wyborny
2011-06-14 18:51 ` Ben Hutchings
2011-06-14 20:19   ` Wyborny, Carolyn
2011-06-16 23:53     ` Ben Hutchings
2011-06-17  3:33 ` David Miller
2011-06-17 15:50   ` Wyborny, Carolyn
2011-06-17 18:54     ` David Miller [this message]
2011-06-21 17:23       ` Wyborny, Carolyn
2011-06-21 17:38         ` Ben Hutchings
2011-06-30 17:52           ` Wyborny, Carolyn
2011-06-30 18:06             ` Ben Hutchings

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110617.145420.866989290749857501.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=bhutchings@solarflare.com \
    --cc=carolyn.wyborny@intel.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).