From: David Miller <davem@davemloft.net>
To: shemminger@vyatta.com
Cc: a.reversat@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH 001/001] vlan: don't call ndo_vlan_rx_register on hardware that doesn't have vlan support
Date: Fri, 17 Jun 2011 15:11:53 -0400 (EDT) [thread overview]
Message-ID: <20110617.151153.65315210241455903.davem@davemloft.net> (raw)
In-Reply-To: <20110617120032.6ed3ae3c@nehalam.ftrdhcpuser.net>
From: Stephen Hemminger <shemminger@vyatta.com>
Date: Fri, 17 Jun 2011 12:00:32 -0700
> On Fri, 17 Jun 2011 00:13:10 -0400 (EDT)
> David Miller <davem@davemloft.net> wrote:
>
>> From: Antoine Reversat <a.reversat@gmail.com>
>> Date: Thu, 16 Jun 2011 16:47:13 -0400
>>
>> > This patch removes the call to ndo_vlan_rx_register if the underlying
>> > device doesn't have hardware support for VLAN.
>> > Signed-off-by: Antoine Reversat <a.reversat@gmail.com>
>>
>> Applied, thanks.
>
> Need same check for unregister?
What unregister? There is only ->ndo_vlan_rx_register(), no such
->ndo_vlan_rx_unregister() op exists.
prev parent reply other threads:[~2011-06-17 19:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-16 20:47 [PATCH 001/001] vlan: don't call ndo_vlan_rx_register on hardware that doesn't have vlan support Antoine Reversat
2011-06-17 4:13 ` David Miller
2011-06-17 19:00 ` Stephen Hemminger
2011-06-17 19:11 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110617.151153.65315210241455903.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=a.reversat@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox