From: David Miller <davem@davemloft.net>
To: greearb@candelatech.com
Cc: romieu@fr.zoreil.com, netdev@vger.kernel.org
Subject: Re: [PATCH v2 1/5] net: Support ethtool ops for rx of errored frames.
Date: Sun, 19 Jun 2011 16:24:37 -0700 (PDT) [thread overview]
Message-ID: <20110619.162437.1293948476324391637.davem@davemloft.net> (raw)
In-Reply-To: <4DFE832C.7000100@candelatech.com>
From: Ben Greear <greearb@candelatech.com>
Date: Sun, 19 Jun 2011 16:15:56 -0700
> This would be separate from the 'features' patches that are floating
> around.
netdev->features is how you should implement your patch, please don't
create new facilities.
With netdev->features they can be validated against netdev->hw_features
which, in this case, r8169 would have this feature bit clear.
That's how all of this stuff is designed to work, the driver says what
the hardware can do and thus ethtool generically can validate attempts
to turn on features.
No new facilities are necessary at all.
next prev parent reply other threads:[~2011-06-19 23:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-18 20:47 [PATCH v2 0/5] Ethernet low-level frame debugging support greearb
2011-06-18 20:47 ` [PATCH v2 1/5] net: Support ethtool ops for rx of errored frames greearb
2011-06-18 21:34 ` Francois Romieu
2011-06-19 20:11 ` Ben Greear
2011-06-19 22:48 ` Francois Romieu
2011-06-19 23:15 ` Ben Greear
2011-06-19 23:24 ` David Miller [this message]
2011-06-18 20:47 ` [PATCH v2 2/5] net: Add pkt-type PACKET_INVALID greearb
2011-06-18 20:47 ` [PATCH v2 3/5] e100: Support receiving errored frames greearb
2011-06-20 17:57 ` Ben Hutchings
2011-06-20 18:06 ` Ben Greear
2011-06-18 20:47 ` [PATCH v2 4/5] net: Support sending frame with specified FCS greearb
2011-06-18 20:47 ` [PATCH v2 5/5] e1000e: Support sending frame with custom FCS greearb
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110619.162437.1293948476324391637.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=greearb@candelatech.com \
--cc=netdev@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).