From: David Miller <davem@davemloft.net>
To: buytenh@wantstofly.org
Cc: richardcochran@gmail.com, netdev@vger.kernel.org, eric.dumazet@gmail.com
Subject: Re: [PATCH V3 10/11] mv643xx_eth: enable transmit time stamping.
Date: Mon, 20 Jun 2011 13:55:12 -0700 (PDT) [thread overview]
Message-ID: <20110620.135512.26659219089505445.davem@davemloft.net> (raw)
In-Reply-To: <20110620163524.GD994@wantstofly.org>
From: Lennert Buytenhek <buytenh@wantstofly.org>
Date: Mon, 20 Jun 2011 18:35:24 +0200
> On Mon, Jun 20, 2011 at 09:51:32AM +0200, Richard Cochran wrote:
>
>> This patch enables software (and phy device) transmit time stamping.
>> Compile tested only.
>>
>> Cc: Lennert Buytenhek <buytenh@wantstofly.org>
>> Signed-off-by: Richard Cochran <richard.cochran@omicron.at>
>> ---
>> drivers/net/mv643xx_eth.c | 2 ++
>> 1 files changed, 2 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/net/mv643xx_eth.c b/drivers/net/mv643xx_eth.c
>> index 1b7d2c1..3671714 100644
>> --- a/drivers/net/mv643xx_eth.c
>> +++ b/drivers/net/mv643xx_eth.c
>> @@ -847,6 +847,8 @@ no_csum:
>> /* clear TX_END status */
>> mp->work_tx_end &= ~(1 << txq->index);
>>
>> + skb_tx_timestamp(skb);
>> +
>> /* ensure all descriptors are written before poking hardware */
>> wmb();
>> txq_enable(txq);
>
> This only timestamps the skb _after_ writing the final (cmd_sts) HW TX
> descriptor word, and so if your previous patch is correct (which I don't
> think it is), this would be buggy as well.
Agreed.
I'll apply the other patches and leave this one for now.
next prev parent reply other threads:[~2011-06-20 20:55 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-20 7:51 [PATCH V3 00/11] net: expand time stamping, batch #2 Richard Cochran
2011-06-20 7:51 ` [PATCH V3 01/11] net: export the receive time stamping hook for non-NAPI drivers Richard Cochran
2011-06-20 7:51 ` [PATCH V3 02/11] lib8390: enable transmit and receive time stamping Richard Cochran
2011-06-20 7:51 ` [PATCH V3 03/11] emaclite: " Richard Cochran
2011-06-20 7:51 ` [PATCH V3 04/11] ll_temac: " Richard Cochran
2011-06-20 7:51 ` [PATCH V3 05/11] fec_mpc52xx: " Richard Cochran
2011-06-20 7:51 ` [PATCH V3 06/11] macb: enable transmit " Richard Cochran
2011-06-20 7:51 ` [PATCH V3 07/11] fs_enet: " Richard Cochran
2011-06-20 7:51 ` [PATCH V3 08/11] smsc911x: " Richard Cochran
2011-06-20 7:51 ` [PATCH V3 09/11] pxa168_eth: " Richard Cochran
2011-06-20 7:51 ` [PATCH V3 10/11] mv643xx_eth: " Richard Cochran
2011-06-20 16:35 ` Lennert Buytenhek
2011-06-20 20:55 ` David Miller [this message]
2011-06-21 4:35 ` [PATCH V4] " Richard Cochran
2011-06-21 23:01 ` David Miller
2011-06-20 7:51 ` [PATCH V3 11/11] ucc_geth: " Richard Cochran
2011-06-20 20:57 ` [PATCH V3 00/11] net: expand time stamping, batch #2 David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110620.135512.26659219089505445.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=buytenh@wantstofly.org \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).