From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lennert Buytenhek Subject: Re: [PATCH V3 10/11] mv643xx_eth: enable transmit time stamping. Date: Mon, 20 Jun 2011 18:35:24 +0200 Message-ID: <20110620163524.GD994@wantstofly.org> References: <96e6a2899b55ac1272cee8ce63e2549e24a10386.1308556146.git.richard.cochran@omicron.at> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev@vger.kernel.org, David Miller , Eric Dumazet To: Richard Cochran Return-path: Received: from fw.wantstofly.org ([80.101.37.227]:58077 "EHLO mail.wantstofly.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751452Ab1FTQf0 (ORCPT ); Mon, 20 Jun 2011 12:35:26 -0400 Content-Disposition: inline In-Reply-To: <96e6a2899b55ac1272cee8ce63e2549e24a10386.1308556146.git.richard.cochran@omicron.at> Sender: netdev-owner@vger.kernel.org List-ID: On Mon, Jun 20, 2011 at 09:51:32AM +0200, Richard Cochran wrote: > This patch enables software (and phy device) transmit time stamping. > Compile tested only. > > Cc: Lennert Buytenhek > Signed-off-by: Richard Cochran > --- > drivers/net/mv643xx_eth.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/drivers/net/mv643xx_eth.c b/drivers/net/mv643xx_eth.c > index 1b7d2c1..3671714 100644 > --- a/drivers/net/mv643xx_eth.c > +++ b/drivers/net/mv643xx_eth.c > @@ -847,6 +847,8 @@ no_csum: > /* clear TX_END status */ > mp->work_tx_end &= ~(1 << txq->index); > > + skb_tx_timestamp(skb); > + > /* ensure all descriptors are written before poking hardware */ > wmb(); > txq_enable(txq); This only timestamps the skb _after_ writing the final (cmd_sts) HW TX descriptor word, and so if your previous patch is correct (which I don't think it is), this would be buggy as well.