From: Randy Dunlap <randy.dunlap@oracle.com>
To: Andrew Morton <akpm@linux-foundation.org>, davem@davemloft.net
Cc: netdev@vger.kernel.org, bugme-daemon@bugzilla.kernel.org,
hilld@binarystorm.net
Subject: [PATCH] netconsole: fix build when CONFIG_NETCONSOLE_DYNAMIC is turned on
Date: Mon, 20 Jun 2011 21:25:04 -0700 [thread overview]
Message-ID: <20110620212504.e639ad5c.randy.dunlap@oracle.com> (raw)
In-Reply-To: <20110620122835.444f16d7.akpm@linux-foundation.org>
From: Randy Dunlap <randy.dunlap@oracle.com>
When NETCONSOLE_DYNAMIC=y and CONFIGFS_FS=m, there are build errors
in netconsole:
drivers/built-in.o: In function `drop_netconsole_target':
netconsole.c:(.text+0x1a100f): undefined reference to `config_item_put'
drivers/built-in.o: In function `make_netconsole_target':
netconsole.c:(.text+0x1a10b9): undefined reference to `config_item_init_type_name'
drivers/built-in.o: In function `write_msg':
netconsole.c:(.text+0x1a11a4): undefined reference to `config_item_get'
netconsole.c:(.text+0x1a1211): undefined reference to `config_item_put'
drivers/built-in.o: In function `netconsole_netdev_event':
netconsole.c:(.text+0x1a12cc): undefined reference to `config_item_put'
netconsole.c:(.text+0x1a12ec): undefined reference to `config_item_get'
netconsole.c:(.text+0x1a1366): undefined reference to `config_item_put'
drivers/built-in.o: In function `init_netconsole':
netconsole.c:(.init.text+0x953a): undefined reference to `config_group_init'
netconsole.c:(.init.text+0x9560): undefined reference to `configfs_register_subsystem'
drivers/built-in.o: In function `dynamic_netconsole_exit':
netconsole.c:(.exit.text+0x809): undefined reference to `configfs_unregister_subsystem'
so make NETCONSOLE_DYNAMIC require CONFIGFS_FS=y to fix the build errors.
This is one possible fix.
Fixes https://bugzilla.kernel.org/show_bug.cgi?id=37992
Reported-by: David Hill <hilld@binarystorm.net>
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
drivers/net/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- lnx-30-rc3.orig/drivers/net/Kconfig
+++ lnx-30-rc3/drivers/net/Kconfig
@@ -3416,7 +3416,7 @@ config NETCONSOLE
config NETCONSOLE_DYNAMIC
bool "Dynamic reconfiguration of logging targets"
- depends on NETCONSOLE && SYSFS && CONFIGFS_FS
+ depends on NETCONSOLE && SYSFS && CONFIGFS_FS=y
help
This option enables the ability to dynamically reconfigure target
parameters (interface, IP addresses, port numbers, MAC addresses)
next prev parent reply other threads:[~2011-06-21 4:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <bug-37992-10286@https.bugzilla.kernel.org/>
2011-06-20 19:28 ` [Bugme-new] [Bug 37992] New: It's not possible to compile kernel if CONFIG_NETCONSOLE_DYNAMIC is turned on Andrew Morton
2011-06-21 4:25 ` Randy Dunlap [this message]
2011-06-21 12:45 ` [PATCH] netconsole: fix build when " Ben Hutchings
2011-06-21 14:05 ` Randy Dunlap
2011-06-21 18:01 ` [PATCH v2] " Randy Dunlap
2011-06-21 23:26 ` David Miller
2011-06-21 12:50 ` [PATCH] " WANG Cong
2011-06-21 16:12 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110620212504.e639ad5c.randy.dunlap@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=bugme-daemon@bugzilla.kernel.org \
--cc=davem@davemloft.net \
--cc=hilld@binarystorm.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).