From mboxrd@z Thu Jan 1 00:00:00 1970 From: "J. Bruce Fields" Subject: Re: [PATCH] svcauth_unix.c: quiet sparse noise Date: Tue, 21 Jun 2011 18:44:30 -0400 Message-ID: <20110621224430.GC28047@fieldses.org> References: <201106201819.12839.hartleys@visionengravers.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Linux Kernel , netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Trond.Myklebust-HgOvQuBEEgTQT0dZR+AlfA@public.gmane.org, neilb-l3A5Bk7waGM@public.gmane.org, davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org To: H Hartley Sweeten Return-path: Content-Disposition: inline In-Reply-To: <201106201819.12839.hartleys-3FF4nKcrg1dE2c76skzGb0EOCMrvLtNR@public.gmane.org> Sender: linux-nfs-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: netdev.vger.kernel.org On Mon, Jun 20, 2011 at 06:19:12PM -0700, H Hartley Sweeten wrote: > Like svcauth_unix, the symbol svcauth_null is used external from this > file. Declare it as extern to quiet the following sparse noise: > > warning: symbol 'svcauth_null' was not declared. Should it be static? Also applying for 3.1.--b. > > Signed-off-by: H Hartley Sweeten > Cc: Trond Myklebust > Cc: "J. Bruce Fields" > Cc: Neil Brown > Cc: "David S. Miller" > > --- > > diff --git a/net/sunrpc/svcauth_unix.c b/net/sunrpc/svcauth_unix.c > index c8e1021..62e49e2 100644 > --- a/net/sunrpc/svcauth_unix.c > +++ b/net/sunrpc/svcauth_unix.c > @@ -36,6 +36,7 @@ struct unix_domain { > /* other stuff later */ > }; > > +extern struct auth_ops svcauth_null; > extern struct auth_ops svcauth_unix; > > static void svcauth_unix_domain_release(struct auth_domain *dom) -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html