From: "Michael Büsch" <m@bues.ch>
To: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] ssb: use pci_dev->revision
Date: Thu, 23 Jun 2011 17:09:08 +0200 [thread overview]
Message-ID: <20110623170908.1417f933@maggie> (raw)
In-Reply-To: <201106231849.53030.sshtylyov@ru.mvista.com>
On Thu, 23 Jun 2011 18:49:52 +0400
Sergei Shtylyov <sshtylyov@ru.mvista.com> wrote:
> The bus scan code reads PCI revision ID from the PCI configuration register
> while it's already stored by PCI subsystem in the 'revision' field of 'struct
> pci_dev'...
>
> Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
>
> ---
> The patch is against the recent Linus' tree.
>
> There's another place where the revision ID register is read but as 16-bit
> entity (probably by mistake though), so I didn't convert it...
Where is that?
> drivers/ssb/scan.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> Index: linux-2.6/drivers/ssb/scan.c
> ===================================================================
> --- linux-2.6.orig/drivers/ssb/scan.c
> +++ linux-2.6/drivers/ssb/scan.c
> @@ -310,8 +310,7 @@ int ssb_bus_scan(struct ssb_bus *bus,
> } else {
> if (bus->bustype == SSB_BUSTYPE_PCI) {
> bus->chip_id = pcidev_to_chipid(bus->host_pci);
> - pci_read_config_byte(bus->host_pci, PCI_REVISION_ID,
> - &bus->chip_rev);
> + bus->chip_rev = bus->host_pci->revision;
> bus->chip_package = 0;
> } else {
> bus->chip_id = 0x4710;
>
next prev parent reply other threads:[~2011-06-23 15:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-23 14:49 [PATCH] ssb: use pci_dev->revision Sergei Shtylyov
2011-06-23 15:09 ` Michael Büsch [this message]
2011-06-23 15:11 ` Sergei Shtylyov
2011-06-23 15:32 ` Michael Büsch
2011-06-24 11:20 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110623170908.1417f933@maggie \
--to=m@bues.ch \
--cc=netdev@vger.kernel.org \
--cc=sshtylyov@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).