Netdev List
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: shyam.iyer.t@gmail.com
Cc: netdev@vger.kernel.org, rmody@brocade.com, ddutt@brocadel.com,
	shyam_iyer@dell.com
Subject: Re: [PATCH] [net][bna] Fix call trace when interrupts are disabled while sleeping function kzalloc is called
Date: Mon, 27 Jun 2011 16:07:06 -0700 (PDT)	[thread overview]
Message-ID: <20110627.160706.1453191829412045606.davem@davemloft.net> (raw)
In-Reply-To: <1309206092-23064-1-git-send-email-shyam_iyer@dell.com>

From: Shyam Iyer <shyam.iyer.t@gmail.com>
Date: Mon, 27 Jun 2011 16:21:32 -0400

> The kzalloc sleeps and disabling interrupts(spin_lock_irqsave)
> causes oops like the one.

What if ->cfg_flags changes while you have dropped the lock?

If the lock doesn't protect those flags, what was it being
taken for in the first place?

  reply	other threads:[~2011-06-27 23:08 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-27 20:21 [PATCH] [net][bna] Fix call trace when interrupts are disabled while sleeping function kzalloc is called Shyam Iyer
2011-06-27 23:07 ` David Miller [this message]
2011-06-28 16:29   ` Shyam_Iyer
2011-06-28 17:27     ` Rasesh Mody
2011-06-28 18:48       ` Shyam_Iyer
2011-06-28  0:51 ` Rasesh Mody
2011-06-28 16:32   ` Shyam_Iyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110627.160706.1453191829412045606.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=ddutt@brocadel.com \
    --cc=netdev@vger.kernel.org \
    --cc=rmody@brocade.com \
    --cc=shyam.iyer.t@gmail.com \
    --cc=shyam_iyer@dell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox