From: David Miller <davem@davemloft.net>
To: mcarlson@broadcom.com, jdmason@kudzu.us
Cc: mchan@broadcom.com, netdev@vger.kernel.org
Subject: Re: [PATCH 15/19 v2] tg3: remove unnecessary read of PCI_CAP_ID_EXP
Date: Mon, 27 Jun 2011 21:39:32 -0700 (PDT) [thread overview]
Message-ID: <20110627.213932.828761097349347608.davem@davemloft.net> (raw)
In-Reply-To: <20110627233352.GA6223@mcarlson.broadcom.com>
From: "Matt Carlson" <mcarlson@broadcom.com>, "Jon Mason" <jdmason@kudzu.us>
Date: Mon, 27 Jun 2011 16:33:52 -0700
> On Mon, Jun 27, 2011 at 03:56:50PM -0700, Jon Mason wrote:
>> The PCIE capability offset is saved during PCI bus walking. Use the
>> value from pci_dev instead of checking in the driver and saving it off
>> the the driver specific structure. It will remove an unnecessary search
>> in the PCI configuration space if this value is referenced instead of
>> reacquiring it.
>>
>> v2 of the patch re-adds the PCI_EXPRESS flag and adds comments
>> describing why it is necessary.
>>
>> Signed-off-by: Jon Mason <jdmason@kudzu.us>
...
> Sorry to be a stickler, but can we convert all occurances of
> 'tp->pdev->pcie_cap' to pci_pcie_cap(tp->pdev)? If the PCI layer is
> taking control of that variable, the driver shouldn't be accessing it
> directly if it can help it.
I did this while adding this patch, thanks.
prev parent reply other threads:[~2011-06-28 4:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1309196854-16232-1-git-send-email-jdmason@kudzu.us>
[not found] ` <20110627184203.GA5817@mcarlson.broadcom.com>
[not found] ` <BANLkTi=-aoj=zg7BZbkzVikF7V9Si8c1xA@mail.gmail.com>
2011-06-27 20:38 ` [PATCH 15/19] tg3: remove unnecessary read of PCI_CAP_ID_EXP Matt Carlson
2011-06-27 22:56 ` [PATCH 15/19 v2] " Jon Mason
2011-06-27 23:33 ` Matt Carlson, Jon Mason
2011-06-28 4:39 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110627.213932.828761097349347608.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jdmason@kudzu.us \
--cc=mcarlson@broadcom.com \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).