From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kurt Van Dijck Subject: Re: [PATCH 1/2] can: bfin_can: simplify xmit id1 setup Date: Mon, 27 Jun 2011 09:43:55 +0200 Message-ID: <20110627074355.GA318@e-circ.dyndns.org> References: <1308925982-14645-1-git-send-email-vapier@gentoo.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: socketcan-core-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, "David S. Miller" , Wolfgang Grandegger , uclinux-dist-devel-ZG0+EudsQA8dtHy/vicBwGD2FQJk+8+b@public.gmane.org To: Mike Frysinger Return-path: Content-Disposition: inline In-Reply-To: <1308925982-14645-1-git-send-email-vapier-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: socketcan-core-bounces-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org Errors-To: socketcan-core-bounces-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org List-Id: netdev.vger.kernel.org On Fri, Jun 24, 2011 at 10:33:01AM -0400, Mike Frysinger wrote: > If we look closely, the 4 writes to TRANSMIT_CHL.id1 can be collapsed > down into much simpler code. So do just that. > > This also fixes a build failure due to the I/O macros no longer > getting pulled in. Their minor (and accidental) usage here gets > dropped as part of the unification. > > Signed-off-by: Mike Frysinger Nice cleanup. Acked-by: Kurt Van Dijck