From: "Guo-Fu Tseng" <cooldavid@cooldavid.org>
To: "Guo-Fu Tseng" <cooldavid@cooldavid.org>,
"David Miller" <davem@davemloft.net>
Cc: "linux-netdev" <netdev@vger.kernel.org>,
"Aries Lee" <arieslee@jmicron.com>,
"Devinchiu" <devinchiu@jmicron.com>
Subject: Re: [PATCH net-next-2.6 2/2] jme: Cleanup PM operations after using new PM API
Date: Tue, 28 Jun 2011 19:19:31 +0800 [thread overview]
Message-ID: <20110628111732.M60965@cooldavid.org> (raw)
In-Reply-To: <1309238615-25590-2-git-send-email-cooldavid@cooldavid.org>
On Tue, 28 Jun 2011 13:23:35 +0800, Guo-Fu Tseng wrote
> From: Guo-Fu Tseng <cooldavid@cooldavid.org>
>
> 1. Using enum name instead of numeric value.
> 2. device_set_wakeup_enable expect bool argument
> adding !!() to the argument to be passed.
> 3. Remove non-hardware related operations from
> jme_clear_pm()
> 4. Reuse jme_clear_pm() in jme_resume()
> 5. Clear wakeup event indicator bits(call jme_clear_pm())
> before going to sleep.
> 6. Check for wakeup setting while shutdown
> Turn off PHY if wakeup is not enabled.
> Power-safe PHY(lower speed) if wakeup is enabled.
>
> Signed-off-by: Guo-Fu Tseng <cooldavid@cooldavid.org>
Dear Davem:
Please ignore this patch.
I'll resend a cleaner version later.
Sorry for the inconvenience.
Guo-Fu Tseng
next prev parent reply other threads:[~2011-06-28 11:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-28 5:23 [PATCH net-next-2.6 1/2] jme: Fix compile warning introduced by new pm macro Guo-Fu Tseng
2011-06-28 5:23 ` [PATCH net-next-2.6 2/2] jme: Cleanup PM operations after using new PM API Guo-Fu Tseng
2011-06-28 11:19 ` Guo-Fu Tseng [this message]
2011-07-01 6:54 ` [PATCH net-next-2.6 1/2] jme: Fix compile warning introduced by new pm macro David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110628111732.M60965@cooldavid.org \
--to=cooldavid@cooldavid.org \
--cc=arieslee@jmicron.com \
--cc=davem@davemloft.net \
--cc=devinchiu@jmicron.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).