From: David Miller <davem@davemloft.net>
To: tklauser@distanz.ch
Cc: grundler@parisc-linux.org, netdev@vger.kernel.org
Subject: Re: [PATCH net-next] net: de4x5: Omit check for multicast bit in netdev_for_each_mc_addr
Date: Thu, 30 Jun 2011 23:57:30 -0700 (PDT) [thread overview]
Message-ID: <20110630.235730.726339338074212677.davem@davemloft.net> (raw)
In-Reply-To: <1309349760-1776-1-git-send-email-tklauser@distanz.ch>
From: Tobias Klauser <tklauser@distanz.ch>
Date: Wed, 29 Jun 2011 14:16:00 +0200
> There is no need to check for the address being a multicast address in
> the netdev_for_each_mc_addr loop, so remove it.
>
> Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Please build test your patches!
> @@ -1954,7 +1954,6 @@ SetMulticastFilter(struct net_device *dev)
> u16 hashcode;
> u32 omr, crc;
> char *pa;
> - unsigned char *addrs;
>
> omr = inl(DE4X5_OMR);
> omr &= ~(OMR_PR | OMR_PM);
You removed this local variable 'addrs' but you did not remove
all uses of that variable, so the build will fail.
next prev parent reply other threads:[~2011-07-01 6:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-29 12:16 [PATCH net-next] net: de4x5: Omit check for multicast bit in netdev_for_each_mc_addr Tobias Klauser
2011-07-01 6:57 ` David Miller [this message]
2011-07-01 7:25 ` Tobias Klauser
2011-07-01 7:31 ` David Miller
2011-07-01 7:37 ` [PATCH net-next v2] " Tobias Klauser
2011-07-01 8:51 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110630.235730.726339338074212677.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=grundler@parisc-linux.org \
--cc=netdev@vger.kernel.org \
--cc=tklauser@distanz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).