From: David Miller <davem@davemloft.net>
To: sebastian.belden@googlemail.com
Cc: netdev@vger.kernel.org, joe@perches.com, sebastian.poehn@belden.com
Subject: Re: [PATCH] gianfar: code cleanups
Date: Fri, 01 Jul 2011 17:46:15 -0700 (PDT) [thread overview]
Message-ID: <20110701.174615.1986418433247529596.davem@davemloft.net> (raw)
In-Reply-To: <1309510843.10177.10.camel@DENEC1DT0191>
From: "Sebastian Pöhn" <sebastian.belden@googlemail.com>
Date: Fri, 01 Jul 2011 11:00:43 +0200
> # moves if_vlan.h include from gianfar.c to gianfar.h
Please don't do this, keep the explicit includes as close
to the actual dependencies as possible. With your change
all of the other source files will load in and parse if_vlan.h
even though they have no need for it.
prev parent reply other threads:[~2011-07-02 0:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-01 9:00 [PATCH] gianfar: code cleanups Sebastian Pöhn
2011-07-02 0:46 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110701.174615.1986418433247529596.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=joe@perches.com \
--cc=netdev@vger.kernel.org \
--cc=sebastian.belden@googlemail.com \
--cc=sebastian.poehn@belden.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox