From: Florian Westphal <fw@strlen.de>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Florian Westphal <fw@strlen.de>,
Patrick McHardy <kaber@trash.net>, Eric Leblond <eric@regit.org>,
sclark46@earthlink.net, Kuzin Andrey <kuzinandrey@yandex.ru>,
Anders Nilsson Plymoth <lanilsson@gmail.com>,
netfilter-devel <netfilter-devel@vger.kernel.org>,
netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH 1/2] nfnetlink: add RCU in nfnetlink_rcv_msg()
Date: Fri, 1 Jul 2011 16:11:25 +0200 [thread overview]
Message-ID: <20110701141125.GS16021@Chamillionaire.breakpoint.cc> (raw)
In-Reply-To: <1309534078.2599.25.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC>
Eric Dumazet <eric.dumazet@gmail.com> wrote:
> Le vendredi 01 juillet 2011 à 09:49 +0200, Florian Westphal a écrit :
> > But I guess even having to grab a refcount would be
> > a huge win as opposed to holding on to the nfnl mutex...
> >
> > We'd also need to audit all ->call implementations; most
> > of them assume the nfnl_mutex is being hold.
>
> We can do another way : Introduce a new ->call_rcu() implementation
> and convert places where we prefer not holding nfnf_mutex.
> If/when all places are converted, remove the ->call() field for good.
Sounds reasonable to me.
Both patches look great, thanks a lot for doing this Eric!
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2011-07-01 14:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1309416426.2532.119.camel@edumazet-laptop>
[not found] ` <4E0C278B.7010403@yandex.ru>
[not found] ` <1309433652.1994.7.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC>
[not found] ` <4E0C651A.1000300@trash.net>
[not found] ` <1309446900.1994.17.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC>
[not found] ` <4E0C8902.8070303@earthlink.net>
[not found] ` <4E0C8D7F.3000902@trash.net>
[not found] ` <1309453730.5846.31.camel@tiger.regit.org>
[not found] ` <1309455919.2515.3.camel@edumazet-laptop>
[not found] ` <1309503610.2515.18.camel@edumazet-laptop>
[not found] ` <20110701074936.GR16021@Chamillionaire.breakpoint.cc>
2011-07-01 15:27 ` [PATCH 1/2] nfnetlink: add RCU in nfnetlink_rcv_msg() Eric Dumazet
2011-07-01 14:11 ` Florian Westphal [this message]
2011-07-05 13:22 ` Patrick McHardy
2011-07-18 14:06 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110701141125.GS16021@Chamillionaire.breakpoint.cc \
--to=fw@strlen.de \
--cc=eric.dumazet@gmail.com \
--cc=eric@regit.org \
--cc=kaber@trash.net \
--cc=kuzinandrey@yandex.ru \
--cc=lanilsson@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=sclark46@earthlink.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).