From: "Gustavo F. Padovan" <padovan-Y3ZbgMPKUGA34EUeqzHoZw@public.gmane.org>
To: Joe Perches <joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
Cc: Marcel Holtmann <marcel-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org>,
"David S. Miller" <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>,
linux-bluetooth-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] bluetooth: Add bt_printk
Date: Fri, 1 Jul 2011 16:03:27 -0300 [thread overview]
Message-ID: <20110701190327.GD23683@joana> (raw)
In-Reply-To: <f06f1d8f4185db431a038c328c42caf4fe270dd0.1309418368.git.joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
Hi Joe,
* Joe Perches <joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org> [2011-06-30 00:19:51 -0700]:
> Add a local logging function to emit bluetooth specific
> messages. Using vsprintf extension %pV saves code/text
> space.
>
> Convert the current BT_INFO and BT_ERR macros to use bt_printk.
> Remove __func__ from BT_ERR macro (and the uses).
> Prefix "Bluetooth: " to BT_ERR
> Remove __func__ from BT_DBG as function can be prefixed when
> using dynamic_debug.
>
> With allyesconfig:
>
> text data bss dec hex filename
> 129956 8632 36096 174684 2aa5c drivers/bluetooth/built-in.o.new2
> 134402 8632 36064 179098 2bb9a drivers/bluetooth/built-in.o.old
> 14778 1012 3408 19198 4afe net/bluetooth/bnep/built-in.o.new2
> 15067 1012 3408 19487 4c1f net/bluetooth/bnep/built-in.o.old
> 346595 19163 86080 451838 6e4fe net/bluetooth/built-in.o.new2
> 353751 19163 86064 458978 700e2 net/bluetooth/built-in.o.old
> 18483 1172 4264 23919 5d6f net/bluetooth/cmtp/built-in.o.new2
> 18927 1172 4264 24363 5f2b net/bluetooth/cmtp/built-in.o.old
> 19237 1172 5152 25561 63d9 net/bluetooth/hidp/built-in.o.new2
> 19581 1172 5152 25905 6531 net/bluetooth/hidp/built-in.o.old
> 59461 3884 14464 77809 12ff1 net/bluetooth/rfcomm/built-in.o.new2
> 61206 3884 14464 79554 136c2 net/bluetooth/rfcomm/built-in.o.old
>
> with x86 defconfig (and just bluetooth):
>
> $ size net/bluetooth/built-in.o.defconfig.*
> text data bss dec hex filename
> 66358 933 100 67391 1073f net/bluetooth/built-in.o.defconfig.new
> 66643 933 100 67676 1085c net/bluetooth/built-in.o.defconfig.old
>
> Signed-off-by: Joe Perches <joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
I applied this patch with a minimal change in the print format. I changed
'bluetooth' to 'Bluetooth'. Thanks a lot for the patch. ;)
Gustavo
next prev parent reply other threads:[~2011-07-01 19:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1309370457.2208.48.camel@aeonflux>
2011-06-30 1:18 ` [PATCH 0/2] bluetooth: Use current logging styles Joe Perches
2011-06-30 1:18 ` [PATCH 1/2] bluetooth: Rename function bt_err to bt_to_errno Joe Perches
2011-07-01 19:04 ` Gustavo F. Padovan
2011-06-30 1:18 ` [PATCH 2/2] bluetooth: Add bt_printk, convert logging macros to lower case Joe Perches
[not found] ` <dde77465697e4a8fed630a9528cd8c1fcb092ce4.1309396408.git.joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
2011-06-30 3:31 ` Gustavo F. Padovan
2011-06-30 3:47 ` Joe Perches
2011-06-30 7:19 ` [PATCH] bluetooth: Add bt_printk Joe Perches
[not found] ` <f06f1d8f4185db431a038c328c42caf4fe270dd0.1309418368.git.joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
2011-07-01 19:03 ` Gustavo F. Padovan [this message]
2011-07-01 19:36 ` Gustavo F. Padovan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110701190327.GD23683@joana \
--to=padovan-y3zbgmpkuga34eueqzhozw@public.gmane.org \
--cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org \
--cc=joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org \
--cc=linux-bluetooth-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=marcel-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).