From: David Miller <davem@davemloft.net>
To: romieu@fr.zoreil.com
Cc: shanwei@cn.fujitsu.com, netdev@vger.kernel.org,
adobriyan@gmail.com, tj@kernel.org
Subject: Re: [PATCH] net: 8139too: Initial necessary vlan_features to support vlan
Date: Sun, 03 Jul 2011 19:54:23 -0700 (PDT) [thread overview]
Message-ID: <20110703.195423.1809799333507901972.davem@davemloft.net> (raw)
In-Reply-To: <20110702095138.GA4736@electric-eye.fr.zoreil.com>
From: Francois Romieu <romieu@fr.zoreil.com>
Date: Sat, 2 Jul 2011 11:51:38 +0200
> Shan Wei <shanwei@cn.fujitsu.com> :
>> Offload setting of vlan device requires
>> vlan_features to be initialed.
> [...]
>> @@ -993,6 +993,7 @@ static int __devinit rtl8139_init_one (struct pci_dev *pdev,
>> * features
>> */
>> dev->features |= NETIF_F_SG | NETIF_F_HW_CSUM | NETIF_F_HIGHDMA;
>> + dev->vlan_features = dev->features;
>
> /* note: the hardware is not capable of sg/csum/highdma, however
> * through the use of skb_copy_and_csum_dev we enable these
> * features
> */
>
> The commit message is a bit misleading wrt hardware capabilities but the
> patch makes sense.
>
> Acked-by: Francois Romieu <romieu@fr.zoreil.com>
Applied.
prev parent reply other threads:[~2011-07-04 3:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-02 8:06 [PATCH] net: 8139too: Initial necessary vlan_features to support vlan Shan Wei
2011-07-02 9:51 ` Francois Romieu
2011-07-04 2:54 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110703.195423.1809799333507901972.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=adobriyan@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
--cc=shanwei@cn.fujitsu.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).