* [PATCH] net: 8139too: Initial necessary vlan_features to support vlan
@ 2011-07-02 8:06 Shan Wei
2011-07-02 9:51 ` Francois Romieu
0 siblings, 1 reply; 3+ messages in thread
From: Shan Wei @ 2011-07-02 8:06 UTC (permalink / raw)
To: David Miller, 单卫, netdev, Alexey Dobriyan, tj
Offload setting of vlan device requires
vlan_features to be initialed.
Signed-off-by: Shan Wei <shanwei@cn.fujitsu.com>
---
drivers/net/8139too.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/net/8139too.c b/drivers/net/8139too.c
index ed6355c..c2672c6 100644
--- a/drivers/net/8139too.c
+++ b/drivers/net/8139too.c
@@ -993,6 +993,7 @@ static int __devinit rtl8139_init_one (struct pci_dev *pdev,
* features
*/
dev->features |= NETIF_F_SG | NETIF_F_HW_CSUM | NETIF_F_HIGHDMA;
+ dev->vlan_features = dev->features;
dev->irq = pdev->irq;
--
1.7.4.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] net: 8139too: Initial necessary vlan_features to support vlan
2011-07-02 8:06 [PATCH] net: 8139too: Initial necessary vlan_features to support vlan Shan Wei
@ 2011-07-02 9:51 ` Francois Romieu
2011-07-04 2:54 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Francois Romieu @ 2011-07-02 9:51 UTC (permalink / raw)
To: Shan Wei; +Cc: David Miller, netdev, Alexey Dobriyan, tj
Shan Wei <shanwei@cn.fujitsu.com> :
> Offload setting of vlan device requires
> vlan_features to be initialed.
[...]
> @@ -993,6 +993,7 @@ static int __devinit rtl8139_init_one (struct pci_dev *pdev,
> * features
> */
> dev->features |= NETIF_F_SG | NETIF_F_HW_CSUM | NETIF_F_HIGHDMA;
> + dev->vlan_features = dev->features;
/* note: the hardware is not capable of sg/csum/highdma, however
* through the use of skb_copy_and_csum_dev we enable these
* features
*/
The commit message is a bit misleading wrt hardware capabilities but the
patch makes sense.
Acked-by: Francois Romieu <romieu@fr.zoreil.com>
--
Ueimor
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net: 8139too: Initial necessary vlan_features to support vlan
2011-07-02 9:51 ` Francois Romieu
@ 2011-07-04 2:54 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2011-07-04 2:54 UTC (permalink / raw)
To: romieu; +Cc: shanwei, netdev, adobriyan, tj
From: Francois Romieu <romieu@fr.zoreil.com>
Date: Sat, 2 Jul 2011 11:51:38 +0200
> Shan Wei <shanwei@cn.fujitsu.com> :
>> Offload setting of vlan device requires
>> vlan_features to be initialed.
> [...]
>> @@ -993,6 +993,7 @@ static int __devinit rtl8139_init_one (struct pci_dev *pdev,
>> * features
>> */
>> dev->features |= NETIF_F_SG | NETIF_F_HW_CSUM | NETIF_F_HIGHDMA;
>> + dev->vlan_features = dev->features;
>
> /* note: the hardware is not capable of sg/csum/highdma, however
> * through the use of skb_copy_and_csum_dev we enable these
> * features
> */
>
> The commit message is a bit misleading wrt hardware capabilities but the
> patch makes sense.
>
> Acked-by: Francois Romieu <romieu@fr.zoreil.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-07-04 3:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-07-02 8:06 [PATCH] net: 8139too: Initial necessary vlan_features to support vlan Shan Wei
2011-07-02 9:51 ` Francois Romieu
2011-07-04 2:54 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).