* [PATCH] natsemi: silence dma-debug warnings
@ 2011-07-04 5:30 FUJITA Tomonori
2011-07-04 5:34 ` David Miller
0 siblings, 1 reply; 10+ messages in thread
From: FUJITA Tomonori @ 2011-07-04 5:30 UTC (permalink / raw)
To: thockin; +Cc: netdev, jim.cromie
This silences dma-debug warnings:
https://lkml.org/lkml/2011/6/30/341
------------[ cut here ]------------
WARNING: at /home/jimc/projects/lx/linux-2.6/lib/dma-debug.c:820
check_unmap+0x1fe/0x56a()
natsemi 0000:00:06.0: DMA-API: device driver frees DMA memory with
different size [device address=0x0000000006ef0040] [map size=1538
bytes] [unmap size=1522 bytes]
Modules linked in: pc8736x_gpio pc87360 hwmon_vid scx200_gpio nsc_gpio
scx200_hrt scx200_acb i2c_core arc4 rtl8180 mac80211 eeprom_93cx6
cfg80211 pcspkr rfkill scx200 ide_gd_mod ide_pci_generic ohci_hcd
usbcore sc1200 ide_core
Pid: 870, comm: collector Not tainted 3.0.0-rc5-sk-00080-gca56a95 #1
Call Trace:
[<c011a556>] warn_slowpath_common+0x4a/0x5f
[<c02565cb>] ? check_unmap+0x1fe/0x56a
[<c011a5cf>] warn_slowpath_fmt+0x26/0x2a
[<c02565cb>] check_unmap+0x1fe/0x56a
[<c0256aaa>] debug_dma_unmap_page+0x53/0x5b
[<c029d6cd>] pci_unmap_single+0x4d/0x57
[<c029ea0a>] natsemi_poll+0x343/0x5ca
[<c0116f41>] ? try_to_wake_up+0xea/0xfc
[<c0122416>] ? spin_unlock_irq.clone.28+0x18/0x23
[<c02d4667>] net_rx_action+0x3f/0xe5
[<c011e35e>] __do_softirq+0x5b/0xd1
[<c011e303>] ? local_bh_enable+0xa/0xa
<IRQ> [<c011e54b>] ? irq_exit+0x34/0x75
[<c01034b9>] ? do_IRQ+0x66/0x79
[<c034e869>] ? common_interrupt+0x29/0x30
[<c0115ed0>] ? finish_task_switch.clone.118+0x31/0x72
[<c034cb92>] ? schedule+0x3b2/0x3f1
[<c012f4b0>] ? hrtimer_start_range_ns+0x10/0x12
[<c012f4ce>] ? hrtimer_start_expires+0x1c/0x24
[<c034d5aa>] ? schedule_hrtimeout_range_clock+0x8e/0xb4
[<c012ed27>] ? update_rmtp+0x68/0x68
[<c034d5da>] ? schedule_hrtimeout_range+0xa/0xc
[<c017a913>] ? poll_schedule_timeout+0x27/0x3e
[<c017b051>] ? do_select+0x488/0x4cd
[<c0115ee2>] ? finish_task_switch.clone.118+0x43/0x72
[<c01157ad>] ? need_resched+0x14/0x1e
[<c017a99e>] ? poll_freewait+0x74/0x74
[<c01157ad>] ? need_resched+0x14/0x1e
[<c034cbc1>] ? schedule+0x3e1/0x3f1
[<c011e55e>] ? irq_exit+0x47/0x75
[<c01157ad>] ? need_resched+0x14/0x1e
[<c034cf8a>] ? preempt_schedule_irq+0x44/0x4a
[<c034dd1e>] ? need_resched+0x17/0x19
[<c024bc12>] ? put_dec_full+0x7b/0xaa
[<c0240060>] ? blkdev_ioctl+0x434/0x618
[<c024bc70>] ? put_dec+0x2f/0x6d
[<c024c6a5>] ? number.clone.1+0x10b/0x1d0
[<c034cf8a>] ? preempt_schedule_irq+0x44/0x4a
[<c034dd1e>] ? need_resched+0x17/0x19
[<c024d046>] ? vsnprintf+0x225/0x264
[<c024cea0>] ? vsnprintf+0x7f/0x264
[<c018346f>] ? seq_printf+0x22/0x40
[<c01a2fcc>] ? do_task_stat+0x582/0x5a3
[<c017a913>] ? poll_schedule_timeout+0x27/0x3e
[<c017b1b5>] ? core_sys_select+0x11f/0x1a3
[<c017a913>] ? poll_schedule_timeout+0x27/0x3e
[<c01a34a1>] ? proc_tgid_stat+0xd/0xf
[<c012357c>] ? recalc_sigpending+0x32/0x35
[<c0123b9c>] ? __set_task_blocked+0x64/0x6a
[<c011dfb0>] ? timespec_add_safe+0x24/0x48
[<c0123449>] ? spin_unlock_irq.clone.16+0x18/0x23
[<c017b3a1>] ? sys_pselect6+0xe5/0x13e
[<c034dd65>] ? syscall_call+0x7/0xb
[<c0340000>] ? rpc_clntdir_depopulate+0x26/0x30
---[ end trace 180dcac41a50938b ]---
Reported-by: Jim Cromie <jim.cromie@gmail.com>
Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Tested-by: Jim Cromie <jim.cromie@gmail.com>
---
drivers/net/natsemi.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/net/natsemi.c b/drivers/net/natsemi.c
index b78be08..8f8b65a 100644
--- a/drivers/net/natsemi.c
+++ b/drivers/net/natsemi.c
@@ -2360,7 +2360,8 @@ static void netdev_rx(struct net_device *dev, int *work_done, int work_to_do)
PCI_DMA_FROMDEVICE);
} else {
pci_unmap_single(np->pci_dev, np->rx_dma[entry],
- buflen, PCI_DMA_FROMDEVICE);
+ buflen + NATSEMI_PADDING,
+ PCI_DMA_FROMDEVICE);
skb_put(skb = np->rx_skbuff[entry], pkt_len);
np->rx_skbuff[entry] = NULL;
}
--
1.7.2.5
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH] natsemi: silence dma-debug warnings
2011-07-04 5:30 [PATCH] natsemi: silence dma-debug warnings FUJITA Tomonori
@ 2011-07-04 5:34 ` David Miller
2011-07-09 20:11 ` Jim Cromie
0 siblings, 1 reply; 10+ messages in thread
From: David Miller @ 2011-07-04 5:34 UTC (permalink / raw)
To: fujita.tomonori; +Cc: thockin, netdev, jim.cromie
From: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Date: Mon, 4 Jul 2011 14:30:19 +0900
> This silences dma-debug warnings:
>
> https://lkml.org/lkml/2011/6/30/341
...
> Reported-by: Jim Cromie <jim.cromie@gmail.com>
> Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
> Tested-by: Jim Cromie <jim.cromie@gmail.com>
Applied, thanks!
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] natsemi: silence dma-debug warnings
2011-07-04 5:34 ` David Miller
@ 2011-07-09 20:11 ` Jim Cromie
2011-07-10 1:20 ` FUJITA Tomonori
2011-07-10 8:58 ` Michał Mirosław
0 siblings, 2 replies; 10+ messages in thread
From: Jim Cromie @ 2011-07-09 20:11 UTC (permalink / raw)
To: David Miller; +Cc: fujita.tomonori, thockin, netdev
[-- Attachment #1: Type: text/plain, Size: 641 bytes --]
On Sun, Jul 3, 2011 at 11:34 PM, David Miller <davem@davemloft.net> wrote:
> From: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
> Date: Mon, 4 Jul 2011 14:30:19 +0900
>
>> This silences dma-debug warnings:
>>
>> https://lkml.org/lkml/2011/6/30/341
> ...
>> Reported-by: Jim Cromie <jim.cromie@gmail.com>
>> Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
>> Tested-by: Jim Cromie <jim.cromie@gmail.com>
>
> Applied, thanks!
>
I have since seen a similar warning on shutdown,
heres a patch for it.
theres one other callsite, but I havent seen the warning from it,
will try to tickle it at some point.
[-- Attachment #2: 0001-natsemi-fix-another-dma-debug-report.patch --]
[-- Type: text/x-patch, Size: 3026 bytes --]
From 2d81b28645b22100271bdbe2d6859cb49a49166d Mon Sep 17 00:00:00 2001
From: Jim Cromie <jim.cromie@gmail.com>
Date: Sat, 9 Jul 2011 11:44:38 -0600
Subject: [PATCH 1/3] natsemi: fix another dma-debug report
commit 2fb83cd618be34546fb526a9051eceaa95517026
Author: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Date: Sun Jul 3 22:34:29 2011 -0700
Above commit fixed previously reported warning, but I later
noticed another one at shutdown. This commit fixes it.
Theres one other callsite to pci_unmap_single, but I havent seen
it report a problem, so havent included it here.
------------[ cut here ]------------
WARNING: at /home/jimc/projects/lx/linux-2.6/lib/dma-debug.c:820 check_unmap+0x1fe/0x56c()
natsemi 0000:00:06.0: DMA-API: device driver frees DMA memory with different size [device address=0x0000000007356840] [map size=1538 bytes] [unmap size=1522 bytes]
Modules linked in: bridge stp llc x_tables ipv6 pc87360 hwmon_vid scx200_hrt pc8736x_gpio scx200_gpio nsc_gpio scx200_acb i2c_core arc4 rtl8180 mac80211 eeprom_93cx6 cfg80211 pcspkr scx200 rfkill ide_gd_mod ide_pci_generic ohci_hcd usbcore sc1200 ide_core [last unloaded: ebtables]
Pid: 3996, comm: ifconfig Not tainted 3.0.0-rc6-skc-dyndbg+ #104
Call Trace:
[<c011ca97>] warn_slowpath_common+0x4a/0x5f
[<c0261ca5>] ? check_unmap+0x1fe/0x56c
[<c011cb10>] warn_slowpath_fmt+0x26/0x2a
[<c0261ca5>] check_unmap+0x1fe/0x56c
[<c0116505>] ? check_preempt_curr+0x5a/0x6a
[<c0262186>] debug_dma_unmap_page+0x53/0x5b
[<c02aaaf9>] pci_unmap_single+0x4d/0x57
[<c02aab51>] drain_rx+0x4e/0x74
[<c02acc6e>] netdev_close+0x103/0x1b8
[<c02f097e>] ? spin_unlock_bh.clone.30+0x12/0x14
[<c02f10aa>] ? dev_deactivate_many+0xc1/0xef
[<c02e05e9>] __dev_close_many+0x69/0x86
[<c02e0625>] __dev_close+0x1f/0x2c
[<c02e3200>] __dev_change_flags+0x92/0x107
[<c02e32db>] dev_change_flags+0x13/0x3f
[<c031e7ea>] devinet_ioctl+0x248/0x4b3
[<c02e3a9e>] ? dev_ioctl+0x50a/0x54c
[<c031f509>] inet_ioctl+0x8e/0xa7
[<c02d506f>] sock_ioctl+0x1b6/0x1da
[<c02d4eb9>] ? sock_fasync+0x61/0x61
[<c0183db4>] do_vfs_ioctl+0x44d/0x47f
[<c0113cdb>] ? do_page_fault+0x268/0x299
[<c01339d0>] ? __put_cred+0x34/0x36
[<c0177d83>] ? sys_faccessat+0x13e/0x14b
[<c0183e14>] sys_ioctl+0x2e/0x4a
[<c035bc95>] syscall_call+0x7/0xb
---[ end trace 7013a1bdac403e56 ]---
Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
---
drivers/net/natsemi.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/natsemi.c b/drivers/net/natsemi.c
index 8f8b65a..e4bd202 100644
--- a/drivers/net/natsemi.c
+++ b/drivers/net/natsemi.c
@@ -2028,8 +2028,8 @@ static void drain_rx(struct net_device *dev)
np->rx_ring[i].cmd_status = 0;
np->rx_ring[i].addr = cpu_to_le32(0xBADF00D0); /* An invalid address. */
if (np->rx_skbuff[i]) {
- pci_unmap_single(np->pci_dev,
- np->rx_dma[i], buflen,
+ pci_unmap_single(np->pci_dev, np->rx_dma[i],
+ buflen + NATSEMI_PADDING,
PCI_DMA_FROMDEVICE);
dev_kfree_skb(np->rx_skbuff[i]);
}
--
1.7.4.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH] natsemi: silence dma-debug warnings
2011-07-09 20:11 ` Jim Cromie
@ 2011-07-10 1:20 ` FUJITA Tomonori
2011-07-10 1:45 ` Jim Cromie
2011-07-10 14:07 ` David Miller
2011-07-10 8:58 ` Michał Mirosław
1 sibling, 2 replies; 10+ messages in thread
From: FUJITA Tomonori @ 2011-07-10 1:20 UTC (permalink / raw)
To: jim.cromie; +Cc: davem, thockin, netdev
On Sat, 9 Jul 2011 14:11:25 -0600
Jim Cromie <jim.cromie@gmail.com> wrote:
> On Sun, Jul 3, 2011 at 11:34 PM, David Miller <davem@davemloft.net> wrote:
>> From: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
>> Date: Mon, 4 Jul 2011 14:30:19 +0900
>>
>>> This silences dma-debug warnings:
>>>
>>> https://lkml.org/lkml/2011/6/30/341
>> ...
>>> Reported-by: Jim Cromie <jim.cromie@gmail.com>
>>> Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
>>> Tested-by: Jim Cromie <jim.cromie@gmail.com>
>>
>> Applied, thanks!
>>
>
> I have since seen a similar warning on shutdown,
> heres a patch for it.
Oops, I noticed this too but I forgot to send a patch.
The patch looks good to me.
> theres one other callsite, but I havent seen the warning from it,
> will try to tickle it at some point.
Which pci_unmap_single are you talking about?
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] natsemi: silence dma-debug warnings
2011-07-10 1:20 ` FUJITA Tomonori
@ 2011-07-10 1:45 ` Jim Cromie
2011-07-10 1:57 ` FUJITA Tomonori
2011-07-10 14:07 ` David Miller
1 sibling, 1 reply; 10+ messages in thread
From: Jim Cromie @ 2011-07-10 1:45 UTC (permalink / raw)
To: FUJITA Tomonori; +Cc: davem, thockin, netdev
On Sat, Jul 9, 2011 at 7:20 PM, FUJITA Tomonori
<fujita.tomonori@lab.ntt.co.jp> wrote:
> On Sat, 9 Jul 2011 14:11:25 -0600
> Jim Cromie <jim.cromie@gmail.com> wrote:
>
>> On Sun, Jul 3, 2011 at 11:34 PM, David Miller <davem@davemloft.net> wrote:
>>> From: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
>>> Date: Mon, 4 Jul 2011 14:30:19 +0900
>>>
>>>> This silences dma-debug warnings:
>>>>
>>>> https://lkml.org/lkml/2011/6/30/341
>>> ...
>>>> Reported-by: Jim Cromie <jim.cromie@gmail.com>
>>>> Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
>>>> Tested-by: Jim Cromie <jim.cromie@gmail.com>
>>>
>>> Applied, thanks!
>>>
>>
>> I have since seen a similar warning on shutdown,
>> heres a patch for it.
>
> Oops, I noticed this too but I forgot to send a patch.
>
> The patch looks good to me.
>
>
>> theres one other callsite, but I havent seen the warning from it,
>> will try to tickle it at some point.
>
> Which pci_unmap_single are you talking about?
>
2131 static void netdev_tx_done(struct net_device *dev)
2132 {
...
2160 pci_unmap_single(np->pci_dev,np->tx_dma[entry],
2161 np->tx_skbuff[entry]->len,
2162 PCI_DMA_TODEVICE);
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] natsemi: silence dma-debug warnings
2011-07-10 1:45 ` Jim Cromie
@ 2011-07-10 1:57 ` FUJITA Tomonori
2011-07-10 2:10 ` Jim Cromie
0 siblings, 1 reply; 10+ messages in thread
From: FUJITA Tomonori @ 2011-07-10 1:57 UTC (permalink / raw)
To: jim.cromie; +Cc: davem, thockin, netdev
On Sat, 9 Jul 2011 19:45:22 -0600
Jim Cromie <jim.cromie@gmail.com> wrote:
> On Sat, Jul 9, 2011 at 7:20 PM, FUJITA Tomonori
> <fujita.tomonori@lab.ntt.co.jp> wrote:
>> On Sat, 9 Jul 2011 14:11:25 -0600
>> Jim Cromie <jim.cromie@gmail.com> wrote:
>>
>>> On Sun, Jul 3, 2011 at 11:34 PM, David Miller <davem@davemloft.net> wrote:
>>>> From: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
>>>> Date: Mon, 4 Jul 2011 14:30:19 +0900
>>>>
>>>>> This silences dma-debug warnings:
>>>>>
>>>>> https://lkml.org/lkml/2011/6/30/341
>>>> ...
>>>>> Reported-by: Jim Cromie <jim.cromie@gmail.com>
>>>>> Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
>>>>> Tested-by: Jim Cromie <jim.cromie@gmail.com>
>>>>
>>>> Applied, thanks!
>>>>
>>>
>>> I have since seen a similar warning on shutdown,
>>> heres a patch for it.
>>
>> Oops, I noticed this too but I forgot to send a patch.
>>
>> The patch looks good to me.
>>
>>
>>> theres one other callsite, but I havent seen the warning from it,
>>> will try to tickle it at some point.
>>
>> Which pci_unmap_single are you talking about?
>>
>
>
> 2131 static void netdev_tx_done(struct net_device *dev)
> 2132 {
> ...
> 2160 pci_unmap_single(np->pci_dev,np->tx_dma[entry],
> 2161 np->tx_skbuff[entry]->len,
> 2162 PCI_DMA_TODEVICE);
It's pci_unmap_single call for tx_dma buffers. We fixed
pci_unmap_single calls for rx_dma buffers.
Looks like the driver correctlly uses pci_map_single and
pci_unmap_single for tx_dma buffers.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] natsemi: silence dma-debug warnings
2011-07-10 1:57 ` FUJITA Tomonori
@ 2011-07-10 2:10 ` Jim Cromie
2011-07-10 2:18 ` FUJITA Tomonori
0 siblings, 1 reply; 10+ messages in thread
From: Jim Cromie @ 2011-07-10 2:10 UTC (permalink / raw)
To: FUJITA Tomonori; +Cc: davem, thockin, netdev
>>> Which pci_unmap_single are you talking about?
>>>
>>
>>
>> 2131 static void netdev_tx_done(struct net_device *dev)
>> 2132 {
>> ...
>> 2160 pci_unmap_single(np->pci_dev,np->tx_dma[entry],
>> 2161 np->tx_skbuff[entry]->len,
>> 2162 PCI_DMA_TODEVICE);
>
> It's pci_unmap_single call for tx_dma buffers. We fixed
> pci_unmap_single calls for rx_dma buffers.
>
> Looks like the driver correctlly uses pci_map_single and
> pci_unmap_single for tx_dma buffers.
>
thanks for checking.
and oops, the one I was referring to was this one,
patched locally.
possible dma-debug error, unseen
diff --git a/drivers/net/natsemi.c b/drivers/net/natsemi.c
index e4bd202..0df7a47 100644
--- a/drivers/net/natsemi.c
+++ b/drivers/net/natsemi.c
@@ -2007,8 +2007,8 @@ static void drain_tx(struct net_device *dev)
for (i = 0; i < TX_RING_SIZE; i++) {
if (np->tx_skbuff[i]) {
- pci_unmap_single(np->pci_dev,
- np->tx_dma[i], np->tx_skbuff[i]->len,
+ pci_unmap_single(np->pci_dev, np->tx_dma[i],
+ np->tx_skbuff[i]->len + NATSEMI_PADDING,
PCI_DMA_TODEVICE);
dev_kfree_skb(np->tx_skbuff[i]);
dev->stats.tx_dropped++;
again, I havent seen a warning here,
either with or without this patch.
Given the wording of the warning (mismatch, ie > or <, not ==)
I presume I should get a warning if the PADDING is wrong here,
and I actually run this codepath ?
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH] natsemi: silence dma-debug warnings
2011-07-10 2:10 ` Jim Cromie
@ 2011-07-10 2:18 ` FUJITA Tomonori
0 siblings, 0 replies; 10+ messages in thread
From: FUJITA Tomonori @ 2011-07-10 2:18 UTC (permalink / raw)
To: jim.cromie; +Cc: davem, thockin, netdev
On Sat, 9 Jul 2011 20:10:17 -0600
Jim Cromie <jim.cromie@gmail.com> wrote:
>>>> Which pci_unmap_single are you talking about?
>>>>
>>>
>>>
>>> 2131 static void netdev_tx_done(struct net_device *dev)
>>> 2132 {
>>> ...
>>> 2160 pci_unmap_single(np->pci_dev,np->tx_dma[entry],
>>> 2161 np->tx_skbuff[entry]->len,
>>> 2162 PCI_DMA_TODEVICE);
>>
>> It's pci_unmap_single call for tx_dma buffers. We fixed
>> pci_unmap_single calls for rx_dma buffers.
>>
>> Looks like the driver correctlly uses pci_map_single and
>> pci_unmap_single for tx_dma buffers.
>>
>
> thanks for checking.
>
> and oops, the one I was referring to was this one,
> patched locally.
>
>
> possible dma-debug error, unseen
>
> diff --git a/drivers/net/natsemi.c b/drivers/net/natsemi.c
> index e4bd202..0df7a47 100644
> --- a/drivers/net/natsemi.c
> +++ b/drivers/net/natsemi.c
> @@ -2007,8 +2007,8 @@ static void drain_tx(struct net_device *dev)
>
> for (i = 0; i < TX_RING_SIZE; i++) {
> if (np->tx_skbuff[i]) {
> - pci_unmap_single(np->pci_dev,
> - np->tx_dma[i], np->tx_skbuff[i]->len,
> + pci_unmap_single(np->pci_dev, np->tx_dma[i],
> + np->tx_skbuff[i]->len + NATSEMI_PADDING,
> PCI_DMA_TODEVICE);
> dev_kfree_skb(np->tx_skbuff[i]);
> dev->stats.tx_dropped++;
>
> again, I havent seen a warning here,
> either with or without this patch.
>
> Given the wording of the warning (mismatch, ie > or <, not ==)
> I presume I should get a warning if the PADDING is wrong here,
> and I actually run this codepath ?
I don't think you run this code path. And as I wrote, the current code
looks correct.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] natsemi: silence dma-debug warnings
2011-07-09 20:11 ` Jim Cromie
2011-07-10 1:20 ` FUJITA Tomonori
@ 2011-07-10 8:58 ` Michał Mirosław
1 sibling, 0 replies; 10+ messages in thread
From: Michał Mirosław @ 2011-07-10 8:58 UTC (permalink / raw)
To: Jim Cromie; +Cc: David Miller, fujita.tomonori, thockin, netdev
2011/7/9 Jim Cromie <jim.cromie@gmail.com>:
> On Sun, Jul 3, 2011 at 11:34 PM, David Miller <davem@davemloft.net> wrote:
>> From: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
>> Date: Mon, 4 Jul 2011 14:30:19 +0900
>>
>>> This silences dma-debug warnings:
>>>
>>> https://lkml.org/lkml/2011/6/30/341
>> ...
>>> Reported-by: Jim Cromie <jim.cromie@gmail.com>
>>> Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
>>> Tested-by: Jim Cromie <jim.cromie@gmail.com>
>>
>> Applied, thanks!
>>
>
> I have since seen a similar warning on shutdown,
> heres a patch for it.
>
> theres one other callsite, but I havent seen the warning from it,
> will try to tickle it at some point.
[about attached patch]
Why not increase buflen, like in refill_rx()?
Best Regards,
Michał Mirosław
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] natsemi: silence dma-debug warnings
2011-07-10 1:20 ` FUJITA Tomonori
2011-07-10 1:45 ` Jim Cromie
@ 2011-07-10 14:07 ` David Miller
1 sibling, 0 replies; 10+ messages in thread
From: David Miller @ 2011-07-10 14:07 UTC (permalink / raw)
To: fujita.tomonori; +Cc: jim.cromie, thockin, netdev
From: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Date: Sun, 10 Jul 2011 10:20:39 +0900 (JST)
> On Sat, 9 Jul 2011 14:11:25 -0600
> Jim Cromie <jim.cromie@gmail.com> wrote:
>
>> On Sun, Jul 3, 2011 at 11:34 PM, David Miller <davem@davemloft.net> wrote:
>>> From: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
>>> Date: Mon, 4 Jul 2011 14:30:19 +0900
>>>
>>>> This silences dma-debug warnings:
>>>>
>>>> https://lkml.org/lkml/2011/6/30/341
>>> ...
>>>> Reported-by: Jim Cromie <jim.cromie@gmail.com>
>>>> Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
>>>> Tested-by: Jim Cromie <jim.cromie@gmail.com>
>>>
>>> Applied, thanks!
>>>
>>
>> I have since seen a similar warning on shutdown,
>> heres a patch for it.
>
> Oops, I noticed this too but I forgot to send a patch.
>
> The patch looks good to me.
I'll apply this, thanks.
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2011-07-10 14:07 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-07-04 5:30 [PATCH] natsemi: silence dma-debug warnings FUJITA Tomonori
2011-07-04 5:34 ` David Miller
2011-07-09 20:11 ` Jim Cromie
2011-07-10 1:20 ` FUJITA Tomonori
2011-07-10 1:45 ` Jim Cromie
2011-07-10 1:57 ` FUJITA Tomonori
2011-07-10 2:10 ` Jim Cromie
2011-07-10 2:18 ` FUJITA Tomonori
2011-07-10 14:07 ` David Miller
2011-07-10 8:58 ` Michał Mirosław
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).