netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: Chetan.Loke@netscout.com
Cc: eric.dumazet@gmail.com, victor@inliniac.net, netdev@vger.kernel.org
Subject: Re: [PATCH 2/2] packet: Add fanout support.
Date: Tue, 05 Jul 2011 09:08:09 -0700 (PDT)	[thread overview]
Message-ID: <20110705.090809.1320878912859271524.davem@davemloft.net> (raw)
In-Reply-To: <D3F292ADF945FB49B35E96C94C2061B91257D61B@nsmail.netscout.com>

From: "Loke, Chetan" <Chetan.Loke@netscout.com>
Date: Tue, 5 Jul 2011 12:03:29 -0400

> Can we not do something like:
> 
> a = src_ip_addr;
> b = dst_ip_addr;
> 
> if (ip_is_fragment(ip_hdr(skb)))
> 	c = ip_hdr->id;
> else
> 	c = src_port | dest_port ; /* port_32 etc - Similar to what we have today 

A UDP flow can be composed of fragmented and non-fragmented
parts, we want all of the packets from that flow to land
on the same hash.

Your scheme does not provide that essential property.

  reply	other threads:[~2011-07-05 16:08 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-05  4:20 [PATCH 2/2] packet: Add fanout support David Miller
2011-07-05  4:33 ` Eric Dumazet
2011-07-05  4:36   ` David Miller
2011-07-05  6:21 ` Eric Dumazet
2011-07-05  6:56   ` Victor Julien
2011-07-05  7:00     ` Eric Dumazet
2011-07-05  7:06       ` Victor Julien
2011-07-05  7:50       ` David Miller
2011-07-05  7:52         ` Victor Julien
2011-07-05  8:02           ` David Miller
2011-07-05  8:47             ` Hagen Paul Pfeifer
2011-07-05  8:48             ` Victor Julien
2011-07-05  9:01               ` David Miller
2011-07-05 16:03       ` Loke, Chetan
2011-07-05 16:08         ` David Miller [this message]
2011-07-05 16:16         ` Eric Dumazet
2011-07-05 16:21           ` Victor Julien
2011-07-05 16:23             ` Eric Dumazet
2011-07-05 17:15               ` Victor Julien
2011-07-05 18:26                 ` Eric Dumazet
2011-07-05 18:34                   ` Victor Julien
2011-07-05 17:35           ` Loke, Chetan
2011-07-05 18:20             ` Eric Dumazet
2011-07-05 21:10               ` Loke, Chetan
2011-07-05  7:48     ` David Miller
2011-07-05  7:46   ` David Miller
2011-07-05  9:50     ` Eric Dumazet
2011-07-05 10:07       ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110705.090809.1320878912859271524.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=Chetan.Loke@netscout.com \
    --cc=eric.dumazet@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=victor@inliniac.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).