From: David Miller <davem@davemloft.net>
To: herbert@gondor.hengli.com.au
Cc: mike@it-loops.com, netdev@vger.kernel.org
Subject: Re: [BUG] bd4265fe36 bridge: Only flood unreg groups... breaks DHCP setup
Date: Tue, 05 Jul 2011 18:40:44 -0700 (PDT) [thread overview]
Message-ID: <20110705.184044.1261486363010308552.davem@davemloft.net> (raw)
In-Reply-To: <20110705235833.GA5599@gondor.apana.org.au>
From: Herbert Xu <herbert@gondor.hengli.com.au>
Date: Wed, 6 Jul 2011 07:58:33 +0800
> bridge: Always flood broadcast packets
>
> As is_multicast_ether_addr returns true on broadcast packets as
> well, we need to explicitly exclude broadcast packets so that
> they're always flooded. This wasn't an issue before as broadcast
> packets were considered to be an unregistered multicast group,
> which were always flooded. However, as we now only flood such
> packets to router ports, this is no longer acceptable.
>
> Reported-by: Michael Guntsche <mike@it-loops.com>
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Applied.
next prev parent reply other threads:[~2011-07-06 1:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-05 18:43 [BUG] bd4265fe36 bridge: Only flood unreg groups... breaks DHCP setup Michael Guntsche
2011-07-05 23:58 ` Herbert Xu
2011-07-06 1:40 ` David Miller [this message]
2011-07-06 5:06 ` Stephen Hemminger
2011-07-06 5:08 ` Herbert Xu
2011-07-06 5:35 ` Stephen Hemminger
2011-07-06 5:45 ` Herbert Xu
2011-07-06 7:57 ` Michael Guntsche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110705.184044.1261486363010308552.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=herbert@gondor.hengli.com.au \
--cc=mike@it-loops.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).