From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH v2] net: sched: constify tcf_proto and tc_action
Date: Tue, 05 Jul 2011 22:59:21 -0700 (PDT) [thread overview]
Message-ID: <20110705.225921.2065481038863776818.davem@davemloft.net> (raw)
In-Reply-To: <20110705.225633.2168272736556352902.davem@davemloft.net>
From: David Miller <davem@davemloft.net>
Date: Tue, 05 Jul 2011 22:56:33 -0700 (PDT)
> From: David Miller <davem@davemloft.net>
> Date: Tue, 05 Jul 2011 22:36:35 -0700 (PDT)
>
>> From: Eric Dumazet <eric.dumazet@gmail.com>
>> Date: Wed, 06 Jul 2011 06:32:45 +0200
>>
>>> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
>>
>> Applied.
>
> net/sched/cls_cgroup.c:279:2: warning: initialization from incompatible pointer type [enabled by default]
> net/sched/cls_cgroup.c:279:2: warning: (near initialization for ‘cls_cgroup_ops.classify’) [enabled by default]
BTW, is is really so hard for people to do "allmodconfig"
builds?
You can take your chances the first time, but if you need to respin
because of warnings and breakage, the onus is on you to actually do a
real complete build regression test on your changes.
I shouldn't be the one hitting this stuff, you folks should.
next prev parent reply other threads:[~2011-07-06 5:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-05 16:36 [PATCH net-next-2.6] net: sched: constify tcf_proto and tc_action Eric Dumazet
2011-07-06 1:32 ` David Miller
2011-07-06 1:33 ` David Miller
2011-07-06 4:32 ` [PATCH v2] " Eric Dumazet
2011-07-06 5:36 ` David Miller
2011-07-06 5:56 ` David Miller
2011-07-06 5:59 ` David Miller [this message]
2011-07-06 9:25 ` Eric Dumazet
2011-07-06 10:05 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110705.225921.2065481038863776818.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).