From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [BUG] bd4265fe36 bridge: Only flood unreg groups... breaks DHCP setup Date: Tue, 5 Jul 2011 22:06:36 -0700 Message-ID: <20110705220636.6afeb81c@nehalam.ftrdhcpuser.net> References: <20110705204200@it-loops.com> <20110705235833.GA5599@gondor.apana.org.au> <20110705.184044.1261486363010308552.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: herbert@gondor.hengli.com.au, mike@it-loops.com, netdev@vger.kernel.org To: David Miller Return-path: Received: from mail.vyatta.com ([76.74.103.46]:34922 "EHLO mail.vyatta.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751438Ab1GFFGj (ORCPT ); Wed, 6 Jul 2011 01:06:39 -0400 In-Reply-To: <20110705.184044.1261486363010308552.davem@davemloft.net> Sender: netdev-owner@vger.kernel.org List-ID: On Tue, 05 Jul 2011 18:40:44 -0700 (PDT) David Miller wrote: > From: Herbert Xu > Date: Wed, 6 Jul 2011 07:58:33 +0800 > > > bridge: Always flood broadcast packets > > > > As is_multicast_ether_addr returns true on broadcast packets as > > well, we need to explicitly exclude broadcast packets so that > > they're always flooded. This wasn't an issue before as broadcast > > packets were considered to be an unregistered multicast group, > > which were always flooded. However, as we now only flood such > > packets to router ports, this is no longer acceptable. > > > > Reported-by: Michael Guntsche > > Signed-off-by: Herbert Xu > > Applied. Obviously needs to go to stable as well.