From: David Miller <davem@davemloft.net>
To: netdev@vger.kernel.org
Cc: ralf@linux-mips.org, linux-hams@vger.kernel.org
Subject: instant oops with AF_ROSE
Date: Wed, 06 Jul 2011 03:57:35 -0700 (PDT) [thread overview]
Message-ID: <20110706.035735.1271031398642349034.davem@davemloft.net> (raw)
The support for ipv4 over rose devices has been broken for as long as
the code has existed (I went back to 2.0.x just to make sure). Try
this:
modprobe rose
ip link set rose0 up
ip addr add 11.0.0.3/8 dev rose0
ping -b 11.255.255.255
That should crash your box pretty well.
The immediate reason is that rose_rebuild_header() calls
rose_route_frame() with second arg NULL.
The first thing rose_route_frame() does is take that second arg and
dereference it in order to find the appropriate rose neighbour to use.
Again, it has "worked" this way since day one. Ie. it never worked.
Since this has never worked, I think the thing to do is to simply
remove all of the rose device code. It's only used to provide support
for ipv4 over ROSE and it simply never worked.
If someone wants to resurrect this, that's fine, but they'll have
to implement proper header_ops and a real transmit function instead
of the hacky thing it does now where it does the transmit in the
header building routines :-/
next reply other threads:[~2011-07-06 10:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-06 10:57 David Miller [this message]
2011-07-06 11:42 ` instant oops with AF_ROSE Chuck Hast
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110706.035735.1271031398642349034.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-hams@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox