* Re: [Bugme-new] [Bug 38862] New: No support for DGE-530T Rev C1
[not found] <bug-38862-10286@https.bugzilla.kernel.org/>
@ 2011-07-06 21:37 ` Andrew Morton
2011-07-06 21:48 ` James Henderson
0 siblings, 1 reply; 4+ messages in thread
From: Andrew Morton @ 2011-07-06 21:37 UTC (permalink / raw)
To: jameshenderson; +Cc: bugme-daemon, netdev, Stephen Hemminger
(switched to email. Please respond via emailed reply-to-all, not via the
bugzilla web interface).
On Wed, 6 Jul 2011 16:05:36 GMT
bugzilla-daemon@bugzilla.kernel.org wrote:
> https://bugzilla.kernel.org/show_bug.cgi?id=38862
>
> Summary: No support for DGE-530T Rev C1
> Product: Drivers
> Version: 2.5
> Kernel Version: 2.6.39.2
> Platform: All
> OS/Version: Linux
> Tree: Mainline
> Status: NEW
> Severity: normal
> Priority: P1
> Component: Network
> AssignedTo: drivers_network@kernel-bugs.osdl.org
> ReportedBy: jameshenderson@ruggedcom.com
> Regression: No
>
>
> The kernel support DGE-530T REV B2 through the skge driver. The PCI device id
> of REV-B2 is 1186:4302. Rev C1 has a PCI device id of 1186:4302. No driver in
> the current kernel supports this device id/vendor combination. Furthermore,
> this device is not even listed in the device database ->
> http://www.pcidatabase.com/vendor_details.php?id=921 .
>
> On the chip is the following information:
> D-Link
> DLG10028C
> A8A34A1
> GA50 TAIWAN
>
> A sticker on the card reads:
> DGE-530T Rev C1
>
> I am including a picture I took of the card.
>
Did you test simply adding that device to the driver?
--- a/drivers/net/skge.c~a
+++ a/drivers/net/skge.c
@@ -89,6 +89,7 @@ static DEFINE_PCI_DEVICE_TABLE(skge_id_t
{ PCI_DEVICE(PCI_VENDOR_ID_SYSKONNECT, PCI_DEVICE_ID_SYSKONNECT_YU) },
{ PCI_DEVICE(PCI_VENDOR_ID_DLINK, PCI_DEVICE_ID_DLINK_DGE510T) },
{ PCI_DEVICE(PCI_VENDOR_ID_DLINK, 0x4b01) }, /* DGE-530T */
+ { PCI_DEVICE(PCI_VENDOR_ID_DLINK, 0x4302) }, /* DGE-530T Rev C1 */
{ PCI_DEVICE(PCI_VENDOR_ID_MARVELL, 0x4320) },
{ PCI_DEVICE(PCI_VENDOR_ID_MARVELL, 0x5005) }, /* Belkin */
{ PCI_DEVICE(PCI_VENDOR_ID_CNET, PCI_DEVICE_ID_CNET_GIGACARD) },
_
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Bugme-new] [Bug 38862] New: No support for DGE-530T Rev C1
2011-07-06 21:37 ` [Bugme-new] [Bug 38862] New: No support for DGE-530T Rev C1 Andrew Morton
@ 2011-07-06 21:48 ` James Henderson
2011-07-06 21:54 ` Andrew Morton
2011-07-06 22:07 ` Stephen Hemminger
0 siblings, 2 replies; 4+ messages in thread
From: James Henderson @ 2011-07-06 21:48 UTC (permalink / raw)
To: Andrew Morton
Cc: bugme-daemon@bugzilla.kernel.org, netdev@vger.kernel.org,
Stephen Hemminger
Andrew Morton wrote:
> (switched to email. Please respond via emailed reply-to-all, not via the
> bugzilla web interface).
>
> On Wed, 6 Jul 2011 16:05:36 GMT
> bugzilla-daemon@bugzilla.kernel.org wrote:
>
>
>> https://bugzilla.kernel.org/show_bug.cgi?id=38862
>>
>> Summary: No support for DGE-530T Rev C1
>> Product: Drivers
>> Version: 2.5
>> Kernel Version: 2.6.39.2
>> Platform: All
>> OS/Version: Linux
>> Tree: Mainline
>> Status: NEW
>> Severity: normal
>> Priority: P1
>> Component: Network
>> AssignedTo: drivers_network@kernel-bugs.osdl.org
>> ReportedBy: jameshenderson@ruggedcom.com
>> Regression: No
>>
>>
>> The kernel support DGE-530T REV B2 through the skge driver. The PCI device id
>> of REV-B2 is 1186:4302. Rev C1 has a PCI device id of 1186:4302. No driver in
>> the current kernel supports this device id/vendor combination. Furthermore,
>> this device is not even listed in the device database ->
>> http://www.pcidatabase.com/vendor_details.php?id=921 .
>>
>> On the chip is the following information:
>> D-Link
>> DLG10028C
>> A8A34A1
>> GA50 TAIWAN
>>
>> A sticker on the card reads:
>> DGE-530T Rev C1
>>
>> I am including a picture I took of the card.
>>
>>
>
> Did you test simply adding that device to the driver?
>
> --- a/drivers/net/skge.c~a
> +++ a/drivers/net/skge.c
> @@ -89,6 +89,7 @@ static DEFINE_PCI_DEVICE_TABLE(skge_id_t
> { PCI_DEVICE(PCI_VENDOR_ID_SYSKONNECT, PCI_DEVICE_ID_SYSKONNECT_YU) },
> { PCI_DEVICE(PCI_VENDOR_ID_DLINK, PCI_DEVICE_ID_DLINK_DGE510T) },
> { PCI_DEVICE(PCI_VENDOR_ID_DLINK, 0x4b01) }, /* DGE-530T */
> + { PCI_DEVICE(PCI_VENDOR_ID_DLINK, 0x4302) }, /* DGE-530T Rev C1 */
> { PCI_DEVICE(PCI_VENDOR_ID_MARVELL, 0x4320) },
> { PCI_DEVICE(PCI_VENDOR_ID_MARVELL, 0x5005) }, /* Belkin */
> { PCI_DEVICE(PCI_VENDOR_ID_CNET, PCI_DEVICE_ID_CNET_GIGACARD) },
> _
>
>
No I haven't tested that change - I don't have a kernel development
environment setup and unfortunately I don't have any more work time to
budget to the issue beyond reporting it.
Also, I meant to say that Rev B2 has PCI id 1186:4B01 (although you seem
to have figured that out).
Thanks,
James
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Bugme-new] [Bug 38862] New: No support for DGE-530T Rev C1
2011-07-06 21:48 ` James Henderson
@ 2011-07-06 21:54 ` Andrew Morton
2011-07-06 22:07 ` Stephen Hemminger
1 sibling, 0 replies; 4+ messages in thread
From: Andrew Morton @ 2011-07-06 21:54 UTC (permalink / raw)
To: James Henderson
Cc: bugme-daemon@bugzilla.kernel.org, netdev@vger.kernel.org,
Stephen Hemminger
On Wed, 6 Jul 2011 17:48:44 -0400
James Henderson <JamesHenderson@ruggedcom.com> wrote:
> > Did you test simply adding that device to the driver?
> >
> > --- a/drivers/net/skge.c~a
> > +++ a/drivers/net/skge.c
> > @@ -89,6 +89,7 @@ static DEFINE_PCI_DEVICE_TABLE(skge_id_t
> > { PCI_DEVICE(PCI_VENDOR_ID_SYSKONNECT, PCI_DEVICE_ID_SYSKONNECT_YU) },
> > { PCI_DEVICE(PCI_VENDOR_ID_DLINK, PCI_DEVICE_ID_DLINK_DGE510T) },
> > { PCI_DEVICE(PCI_VENDOR_ID_DLINK, 0x4b01) }, /* DGE-530T */
> > + { PCI_DEVICE(PCI_VENDOR_ID_DLINK, 0x4302) }, /* DGE-530T Rev C1 */
> > { PCI_DEVICE(PCI_VENDOR_ID_MARVELL, 0x4320) },
> > { PCI_DEVICE(PCI_VENDOR_ID_MARVELL, 0x5005) }, /* Belkin */
> > { PCI_DEVICE(PCI_VENDOR_ID_CNET, PCI_DEVICE_ID_CNET_GIGACARD) },
> > _
> >
> >
> No I haven't tested that change - I don't have a kernel development
> environment setup and unfortunately I don't have any more work time to
> budget to the issue beyond reporting it.
>
> Also, I meant to say that Rev B2 has PCI id 1186:4B01 (although you seem
> to have figured that out).
OK, I suppose we can add that info thusly:
--- a/drivers/net/skge.c~drivers-net-skgec-support-dlink-dge-530t-rev-c1
+++ a/drivers/net/skge.c
@@ -88,7 +88,8 @@ static DEFINE_PCI_DEVICE_TABLE(skge_id_t
{ PCI_DEVICE(PCI_VENDOR_ID_SYSKONNECT, PCI_DEVICE_ID_SYSKONNECT_GE) },
{ PCI_DEVICE(PCI_VENDOR_ID_SYSKONNECT, PCI_DEVICE_ID_SYSKONNECT_YU) },
{ PCI_DEVICE(PCI_VENDOR_ID_DLINK, PCI_DEVICE_ID_DLINK_DGE510T) },
- { PCI_DEVICE(PCI_VENDOR_ID_DLINK, 0x4b01) }, /* DGE-530T */
+ { PCI_DEVICE(PCI_VENDOR_ID_DLINK, 0x4b01) }, /* DGE-530T Rev B2 */
+ { PCI_DEVICE(PCI_VENDOR_ID_DLINK, 0x4302) }, /* DGE-530T Rev C1 */
{ PCI_DEVICE(PCI_VENDOR_ID_MARVELL, 0x4320) },
{ PCI_DEVICE(PCI_VENDOR_ID_MARVELL, 0x5005) }, /* Belkin */
{ PCI_DEVICE(PCI_VENDOR_ID_CNET, PCI_DEVICE_ID_CNET_GIGACARD) },
_
although that might be misleading if, say, 0x4b01 describes other
revisions.
But there isn't much we can do with this until someone can test the
change.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Bugme-new] [Bug 38862] New: No support for DGE-530T Rev C1
2011-07-06 21:48 ` James Henderson
2011-07-06 21:54 ` Andrew Morton
@ 2011-07-06 22:07 ` Stephen Hemminger
1 sibling, 0 replies; 4+ messages in thread
From: Stephen Hemminger @ 2011-07-06 22:07 UTC (permalink / raw)
To: James Henderson
Cc: Andrew Morton, bugme-daemon@bugzilla.kernel.org,
netdev@vger.kernel.org
On Wed, 6 Jul 2011 17:48:44 -0400
James Henderson <JamesHenderson@ruggedcom.com> wrote:
> Andrew Morton wrote:
> > (switched to email. Please respond via emailed reply-to-all, not via the
> > bugzilla web interface).
> >
> > On Wed, 6 Jul 2011 16:05:36 GMT
> > bugzilla-daemon@bugzilla.kernel.org wrote:
> >
> >
> >> https://bugzilla.kernel.org/show_bug.cgi?id=38862
> >>
> >> Summary: No support for DGE-530T Rev C1
> >> Product: Drivers
> >> Version: 2.5
> >> Kernel Version: 2.6.39.2
> >> Platform: All
> >> OS/Version: Linux
> >> Tree: Mainline
> >> Status: NEW
> >> Severity: normal
> >> Priority: P1
> >> Component: Network
> >> AssignedTo: drivers_network@kernel-bugs.osdl.org
> >> ReportedBy: jameshenderson@ruggedcom.com
> >> Regression: No
> >>
> >>
> >> The kernel support DGE-530T REV B2 through the skge driver. The PCI device id
> >> of REV-B2 is 1186:4302. Rev C1 has a PCI device id of 1186:4302. No driver in
> >> the current kernel supports this device id/vendor combination. Furthermore,
> >> this device is not even listed in the device database ->
> >> http://www.pcidatabase.com/vendor_details.php?id=921 .
> >>
> >> On the chip is the following information:
> >> D-Link
> >> DLG10028C
> >> A8A34A1
> >> GA50 TAIWAN
> >>
> >> A sticker on the card reads:
> >> DGE-530T Rev C1
> >>
> >> I am including a picture I took of the card.
> >>
> >>
> >
> > Did you test simply adding that device to the driver?
> >
> > --- a/drivers/net/skge.c~a
> > +++ a/drivers/net/skge.c
> > @@ -89,6 +89,7 @@ static DEFINE_PCI_DEVICE_TABLE(skge_id_t
> > { PCI_DEVICE(PCI_VENDOR_ID_SYSKONNECT, PCI_DEVICE_ID_SYSKONNECT_YU) },
> > { PCI_DEVICE(PCI_VENDOR_ID_DLINK, PCI_DEVICE_ID_DLINK_DGE510T) },
> > { PCI_DEVICE(PCI_VENDOR_ID_DLINK, 0x4b01) }, /* DGE-530T */
> > + { PCI_DEVICE(PCI_VENDOR_ID_DLINK, 0x4302) }, /* DGE-530T Rev C1 */
> > { PCI_DEVICE(PCI_VENDOR_ID_MARVELL, 0x4320) },
> > { PCI_DEVICE(PCI_VENDOR_ID_MARVELL, 0x5005) }, /* Belkin */
> > { PCI_DEVICE(PCI_VENDOR_ID_CNET, PCI_DEVICE_ID_CNET_GIGACARD) },
> > _
I will go look at the Marvell Syskonnect driver, they occasionally
up date it with new ID's.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-07-06 22:08 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <bug-38862-10286@https.bugzilla.kernel.org/>
2011-07-06 21:37 ` [Bugme-new] [Bug 38862] New: No support for DGE-530T Rev C1 Andrew Morton
2011-07-06 21:48 ` James Henderson
2011-07-06 21:54 ` Andrew Morton
2011-07-06 22:07 ` Stephen Hemminger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox