From: Dmitry Torokhov <dtor@vmware.com>
To: pv-drivers@vmware.com
Cc: Shreyas Bhatewara <sbhatewara@vmware.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
yongwang@vmware.com
Subject: Re: [Pv-drivers] [PATCH] vmxnet3: round down # of queues to power of two
Date: Wed, 6 Jul 2011 18:08:39 -0700 [thread overview]
Message-ID: <201107061808.39918.dtor@vmware.com> (raw)
In-Reply-To: <alpine.LRH.2.00.1107061751120.3509@sbhatewara-dev1.eng.vmware.com>
On Wednesday, July 06, 2011 05:58:51 PM Shreyas Bhatewara wrote:
>
> + if (!is_power_of_2(num_rx_queues))
> + num_rx_queues = rounddown_pow_of_two(num_rx_queues);
> +
No need to do the check, just do:
num_rx_queues = rounddown_pow_of_two(num_rx_queues);
Thanks,
Dmitry
next prev parent reply other threads:[~2011-07-07 1:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-07 0:58 [PATCH] vmxnet3: round down # of queues to power of two Shreyas Bhatewara
2011-07-07 1:08 ` Dmitry Torokhov [this message]
2011-07-07 1:53 ` [Pv-drivers] " Yong Wang
2011-07-07 1:16 ` [PATCHv2] " Shreyas Bhatewara
2011-07-07 7:26 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201107061808.39918.dtor@vmware.com \
--to=dtor@vmware.com \
--cc=netdev@vger.kernel.org \
--cc=pv-drivers@vmware.com \
--cc=sbhatewara@vmware.com \
--cc=yongwang@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox