From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [Pv-drivers] [PATCH] vmxnet3: round down # of queues to power of two Date: Wed, 6 Jul 2011 18:08:39 -0700 Message-ID: <201107061808.39918.dtor@vmware.com> References: Mime-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Cc: Shreyas Bhatewara , "netdev@vger.kernel.org" , yongwang@vmware.com To: pv-drivers@vmware.com Return-path: Received: from smtp-outbound-2.vmware.com ([65.115.85.73]:4094 "EHLO smtp-outbound-2.vmware.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751857Ab1GGBIk (ORCPT ); Wed, 6 Jul 2011 21:08:40 -0400 Received: from mailhost2.vmware.com (mailhost2.vmware.com [10.16.67.167]) by smtp-outbound-2.vmware.com (Postfix) with ESMTP id 2E1E131008 for ; Wed, 6 Jul 2011 18:08:40 -0700 (PDT) In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On Wednesday, July 06, 2011 05:58:51 PM Shreyas Bhatewara wrote: > > + if (!is_power_of_2(num_rx_queues)) > + num_rx_queues = rounddown_pow_of_two(num_rx_queues); > + No need to do the check, just do: num_rx_queues = rounddown_pow_of_two(num_rx_queues); Thanks, Dmitry