* [patch] dcbnl: unlock on an error path in dcbnl_cee_fill()
@ 2011-07-08 7:27 Dan Carpenter
2011-07-08 16:02 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2011-07-08 7:27 UTC (permalink / raw)
To: Shmulik Ravid
Cc: David S. Miller, John Fastabend, Shmulik Ravid,
open list:NETWORKING [GENERAL], kernel-janitors
We need to release "dcb_lock" which we took on the previous line.
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/net/dcb/dcbnl.c b/net/dcb/dcbnl.c
index 6a015f2..3cb56af 100644
--- a/net/dcb/dcbnl.c
+++ b/net/dcb/dcbnl.c
@@ -1409,7 +1409,7 @@ static int dcbnl_cee_fill(struct sk_buff *skb, struct net_device *netdev)
spin_lock(&dcb_lock);
app = nla_nest_start(skb, DCB_ATTR_CEE_APP_TABLE);
if (!app)
- goto nla_put_failure;
+ goto dcb_unlock;
list_for_each_entry(itr, &dcb_app_list, list) {
if (strncmp(itr->name, netdev->name, IFNAMSIZ) == 0) {
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch] dcbnl: unlock on an error path in dcbnl_cee_fill()
2011-07-08 7:27 [patch] dcbnl: unlock on an error path in dcbnl_cee_fill() Dan Carpenter
@ 2011-07-08 16:02 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2011-07-08 16:02 UTC (permalink / raw)
To: error27; +Cc: shmulikr, john.r.fastabend, netdev, kernel-janitors
From: Dan Carpenter <error27@gmail.com>
Date: Fri, 8 Jul 2011 10:27:24 +0300
> We need to release "dcb_lock" which we took on the previous line.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Applied, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-07-08 16:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-07-08 7:27 [patch] dcbnl: unlock on an error path in dcbnl_cee_fill() Dan Carpenter
2011-07-08 16:02 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).