From: David Miller <davem@davemloft.net>
To: jdelvare@suse.de
Cc: netdev@vger.kernel.org, thockin@hockin.org,
broonie@opensource.wolfsonmicro.com
Subject: Re: [PATCH] net/natsemi: Fix module parameter permissions
Date: Fri, 08 Jul 2011 09:05:56 -0700 (PDT) [thread overview]
Message-ID: <20110708.090556.1065709849750465470.davem@davemloft.net> (raw)
In-Reply-To: <201107081101.28812.jdelvare@suse.de>
From: Jean Delvare <jdelvare@suse.de>
Date: Fri, 8 Jul 2011 11:01:28 +0200
> The third parameter of module_param is supposed to represent sysfs
> file permissions. A value of "1" leads to the following:
>
> $ ls -l /sys/module/natsemi/parameters/
> total 0
> ---------x 1 root root 4096 Jul 8 09:46 dspcfg_workaround
>
> I am changing it to "0" to align with the other module parameters in
> this driver.
>
> Signed-off-by: Jean Delvare <jdelvare@suse.de>
Applied, thanks.
prev parent reply other threads:[~2011-07-08 16:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-08 9:01 [PATCH] net/natsemi: Fix module parameter permissions Jean Delvare
2011-07-08 16:05 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110708.090556.1065709849750465470.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=jdelvare@suse.de \
--cc=netdev@vger.kernel.org \
--cc=thockin@hockin.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).