From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: ronny.meeus@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH] [PATCH] Fix deadlock in af_packet while stressing raw ethernet socket interface
Date: Tue, 12 Jul 2011 01:26:55 -0700 (PDT) [thread overview]
Message-ID: <20110712.012655.1526748393425458264.davem@davemloft.net> (raw)
In-Reply-To: <1310458986.4763.4.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Tue, 12 Jul 2011 10:23:06 +0200
> Le mardi 12 juillet 2011 à 00:19 -0700, David Miller a écrit :
>> From: Eric Dumazet <eric.dumazet@gmail.com>
>> Date: Tue, 12 Jul 2011 08:58:48 +0200
>>
>> > This seems a bug, but in softirq handling in your arch
>>
>> That's not the problem, it's the dev_queue_xmit_nit() code
>> path that interrupt is interrupting.
>
> Isnt it what I said ?
>
> Unless I am mistaken, dev_queue_xmit_nit() is called from
> dev_hard_start_xmit(), and from dev_queue_xmit(), therefore BH
> are/should_be masked. Calling do_softirq() while BH are masked is the
> bug.
>
> Something must be messing the !in_interrupt() test done from irq_exit()
Aha, I see. Yes, this seems to be where the problem are.
prev parent reply other threads:[~2011-07-12 8:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-11 5:04 [PATCH] [PATCH] Fix deadlock in af_packet while stressing raw ethernet socket interface Ronny Meeus
2011-07-12 3:27 ` David Miller
2011-07-12 6:38 ` Ronny Meeus
2011-07-12 6:42 ` David Miller
2011-07-12 6:58 ` Eric Dumazet
2011-07-12 7:19 ` David Miller
2011-07-12 8:23 ` Eric Dumazet
2011-07-12 8:26 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110712.012655.1526748393425458264.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=ronny.meeus@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox