From mboxrd@z Thu Jan 1 00:00:00 1970 From: Randy Dunlap Subject: Re: netdevice: Kill 'feature' test macros. Date: Tue, 12 Jul 2011 12:09:23 -0700 Message-ID: <20110712120923.e90730f8.rdunlap@xenotime.net> References: <20110712.105005.34046159802896038.davem@davemloft.net> <20110712111033.6e3923db@nehalam.ftrdhcpuser.net> <201107122106.21570.arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Stephen Hemminger , David Miller , netdev@vger.kernel.org To: Arnd Bergmann Return-path: Received: from oproxy1-pub.bluehost.com ([66.147.249.253]:44316 "HELO oproxy1-pub.bluehost.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1753267Ab1GLTJ0 (ORCPT ); Tue, 12 Jul 2011 15:09:26 -0400 In-Reply-To: <201107122106.21570.arnd@arndb.de> Sender: netdev-owner@vger.kernel.org List-ID: On Tue, 12 Jul 2011 21:06:21 +0200 Arnd Bergmann wrote: > On Tuesday 12 July 2011 20:10:33 Stephen Hemminger wrote: > > On Tue, 12 Jul 2011 10:50:05 -0700 (PDT) > > David Miller wrote: > > > > > > > > Almost all of these have long outstayed their welcome. > > > > > > And for every one of these macros, there are 10 features for which we > > > didn't get macros added. > > > > > > Let's just delete them all, and get out of habit of doing things this > > > way. > > > > > > Signed-off-by: David S. Miller > > > > Acked-by: Stephen Hemminger > > > > This is sure to break out of tree drivers... > > I guess that's a good thing, but it also breaks these: > > drivers/staging/wlags49_h2/wl_internal.h:#ifdef HAVE_NETDEV_PRIV > drivers/net/cxgb4vf/cxgb4vf_main.c:#ifdef HAVE_NET_DEVICE_OPS > drivers/staging/ft1000/ft1000-usb/ft1000_hw.c:#ifdef HAVE_NET_DEVICE_OPS > net/batman-adv/soft-interface.c:#ifdef HAVE_NET_DEVICE_OPS Really? I thought it would only break: #if UNKNOWN_SYMBOL but not #ifdef UNKNOWN_SYMBOL > Acked-by: Arnd Bergmann > > if the above are taken care of. --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code ***