From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH 4/4] slip: remove dead code within the slip initialization Date: Wed, 13 Jul 2011 02:32:42 -0700 (PDT) Message-ID: <20110713.023242.858769644416598710.davem@davemloft.net> References: Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org To: matvejchikov@gmail.com Return-path: Received: from shards.monkeyblade.net ([198.137.202.13]:57122 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965169Ab1GMJco (ORCPT ); Wed, 13 Jul 2011 05:32:44 -0400 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: From: Matvejchikov Ilya Date: Wed, 13 Jul 2011 11:47:38 +0400 > This following code contains a dead "if (dev).." block: ... > The reason is that the code starting with "if (dev).." is never called as > when we found an empty slot (dev == NULL) we break the loop and "if (dev).." > not works eiter the loop ends and we get out with "i >= slip_maxdev". > > Signed-off-by: Matvejchikov Ilya Applied.