From: David Miller <davem@davemloft.net>
To: mirq-linux@rere.qmqm.pl
Cc: therbert@google.com, bhutchings@solarflare.com, netdev@vger.kernel.org
Subject: Re: [PATCH 07/10] net: remove NETIF_F_NO_CSUM feature
Date: Thu, 14 Jul 2011 17:05:06 -0700 (PDT) [thread overview]
Message-ID: <20110714.170506.1425372007221475085.davem@davemloft.net> (raw)
In-Reply-To: <20110714224445.GA18237@rere.qmqm.pl>
From: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Date: Fri, 15 Jul 2011 00:44:45 +0200
> On Thu, Jul 14, 2011 at 02:31:21PM -0700, David Miller wrote:
>> From: Michał Mirosław <mirq-linux@rere.qmqm.pl>
>> Date: Thu, 14 Jul 2011 22:56:23 +0200
>> > That's why its turned off by default and should be enabled only when user
>> > knows he will win some pps with it.
>> More people are going to lose than win by your change.
>>
>> The nocopy feature helps more real situations than it hurts, the
>> existing default is the best.
>
> I see. I still want to remove NO_CSUM (as I explained in other mail),
> so would you accept replacing it with something more specific to
> nocache-copy feature? READS_DATA maybe? That could be later added to
> sk_route_caps whenever it's known for a route there will be need to
> read packets' data.
I don't actually see what the problem is.
The code wants to conditionalize the nocache-copy feature based upon
whether hardware will checksum the packet or not.
And that's exactly what it's testing.
The reason, of course, is because it doesn't want to enable
nocache-copy if the cpu is just going to read the data back into it's
caches during the checksum. But that's no reason to change the
flag name to have the word "read" instead of "checksum" in it.
next prev parent reply other threads:[~2011-07-15 0:06 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-14 0:10 [PATCH 00/10] net: random cleanups Michał Mirosław
2011-07-14 0:10 ` [PATCH 01/10] net: sctp: fix checksum marking for outgoing packets Michał Mirosław
2011-07-14 21:37 ` David Miller
2011-07-14 0:10 ` [PATCH 02/10] net: m68k/nfeth: Remove wrong usage of dev->flags Michał Mirosław
2011-07-14 21:38 ` David Miller
2011-07-14 0:10 ` [PATCH 06/10] net: remove NETIF_F_ALL_TX_OFFLOADS Michał Mirosław
2011-07-14 21:43 ` David Miller
2011-07-14 21:54 ` Michał Mirosław
2011-07-14 21:58 ` David Miller
2011-07-14 22:34 ` [PATCH 1/1 net] net: fix bonding advertising offloads it can't support Michał Mirosław
2011-07-14 22:37 ` David Miller
2011-07-14 0:10 ` [PATCH 07/10] net: remove NETIF_F_NO_CSUM feature Michał Mirosław
2011-07-14 0:23 ` Ben Hutchings
2011-07-14 0:48 ` Stephen Hemminger
2011-07-14 0:59 ` Ben Hutchings
[not found] ` <CA+mtBx9GXf_+DGB4EabS74Hf+16KKJ78Ty_zK6Y3tC+X634jtA@mail.gmail.com>
2011-07-14 20:56 ` Michał Mirosław
2011-07-14 21:31 ` David Miller
2011-07-14 22:44 ` Michał Mirosław
2011-07-15 0:05 ` David Miller [this message]
2011-07-15 0:28 ` Michał Mirosław
2011-07-14 21:00 ` Michał Mirosław
2011-07-14 0:10 ` [PATCH 03/10] net: vlan: remove reduntant check in ndo_fix_features callback Michał Mirosław
2011-07-14 21:39 ` David Miller
2011-07-14 0:10 ` [PATCH 04/10] net: cleanup vlan_features setting in register_netdev Michał Mirosław
2011-07-14 21:41 ` David Miller
2011-07-14 0:10 ` [PATCH 05/10] net: Disable NOCACHE_COPY by default Michał Mirosław
2011-07-14 0:44 ` Tom Herbert
2011-07-14 0:10 ` [PATCH 09/10] net: remove /sys/class/net/*/features Michał Mirosław
2011-07-14 0:50 ` Stephen Hemminger
2011-07-14 1:03 ` Ben Hutchings
2011-07-14 1:16 ` Stephen Hemminger
2011-07-14 20:46 ` Michał Mirosław
2011-07-14 21:45 ` David Miller
2011-07-14 0:10 ` [PATCH 10/10] net: remove SK_ROUTE_CAPS from meta ematch Michał Mirosław
2011-07-14 0:52 ` Stephen Hemminger
2011-07-14 0:59 ` jamal
2011-07-14 20:50 ` Michał Mirosław
2011-07-14 20:52 ` David Miller
2011-07-14 21:46 ` David Miller
2011-07-14 0:10 ` [PATCH 08/10] net: unexport netdev_fix_features() Michał Mirosław
2011-07-14 21:44 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110714.170506.1425372007221475085.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bhutchings@solarflare.com \
--cc=mirq-linux@rere.qmqm.pl \
--cc=netdev@vger.kernel.org \
--cc=therbert@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).