netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jiri Pirko <jpirko@redhat.com>
To: sandeep.kumar@freescale.com
Cc: netdev@vger.kernel.org, sebastian.poehn@belden.com,
	davem@davemloft.net, B06378@freescale.com
Subject: gianfar vlan
Date: Thu, 14 Jul 2011 15:14:27 +0200	[thread overview]
Message-ID: <20110714131426.GA11691@minipsycho.brq.redhat.com> (raw)

Hi Sandeep.

I'm trying to remove gfar_vlan_rx_register() and move the vlan accel
enabling/disabling to gfar_set_features() -> startup_gfar() ->
gfar_init_mac(). I'm not sure how to handle following lines in
gfar_vlan_rx_register():

/* If parse is no longer required, then disable parser */
if (tempval & RCTRL_REQ_PARSER)
	tempval |= RCTRL_PRSDEP_INIT;
else
	tempval &= ~RCTRL_PRSDEP_INIT;

Should this be done only on disabling vlan accel (both rx an tx)?
Or can I just do that always in startup_gfar() ?

Thanks.

Jirka


             reply	other threads:[~2011-07-14 13:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-14 13:14 Jiri Pirko [this message]
  -- strict thread matches above, loose matches on Subject: below --
2011-07-15  7:59 gianfar vlan Sebastian Pöhn
2011-07-15  9:16 ` Jiri Pirko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110714131426.GA11691@minipsycho.brq.redhat.com \
    --to=jpirko@redhat.com \
    --cc=B06378@freescale.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=sandeep.kumar@freescale.com \
    --cc=sebastian.poehn@belden.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).