From: David Miller <davem@davemloft.net>
To: sebastian.belden@googlemail.com
Cc: netdev@vger.kernel.org, jpirko@redhat.com, sandeep.kumar@freescale.com
Subject: Re: [PATCH] gianfar: rx parser
Date: Fri, 15 Jul 2011 08:06:10 -0700 (PDT) [thread overview]
Message-ID: <20110715.080610.256697325487445331.davem@davemloft.net> (raw)
In-Reply-To: <1310728141.28792.10.camel@DENEC1DT0191>
From: "Sebastian Pöhn" <sebastian.belden@googlemail.com>
Date: Fri, 15 Jul 2011 13:09:01 +0200
> + struct gfar __iomem *regs = NULL;
> + u32 tempval = 0;
> +
> + regs = priv->gfargrp[0].regs;
There is no reason to initialize the variable 'regs' to NULL only to
initialize it to something else 2 lines later.
The initial 'tempval' initialization is also redundant, for the same
reason.
next prev parent reply other threads:[~2011-07-15 15:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-15 11:09 [PATCH] gianfar: rx parser Sebastian Pöhn
2011-07-15 11:41 ` Jiri Pirko
2011-07-15 15:06 ` David Miller [this message]
2011-07-15 19:51 ` Jiri Pirko
2011-07-15 23:00 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110715.080610.256697325487445331.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jpirko@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=sandeep.kumar@freescale.com \
--cc=sebastian.belden@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).