From: David Miller <davem@davemloft.net>
To: krkumar2@in.ibm.com
Cc: netdev@vger.kernel.org, shemminger@vyatta.com
Subject: Re: [PATCH] Fix panic in virtnet_remove
Date: Fri, 15 Jul 2011 08:19:09 -0700 (PDT) [thread overview]
Message-ID: <20110715.081909.1693878001743345571.davem@davemloft.net> (raw)
In-Reply-To: <20110715091650.23026.78221.sendpatchset@krkumar2.in.ibm.com>
From: Krishna Kumar <krkumar2@in.ibm.com>
Date: Fri, 15 Jul 2011 14:46:50 +0530
> modprobe -r virtio_net panics in free_netdev() as the
> dev is already freed in the newly introduced virtnet_free
> (commit 3fa2a1df9094). Since virtnet_remove doesn't require
> dev after unregister, I am removing the free_netdev call
> in virtnet_remove instead of in virtnet_free (which seems
> to be the right place to free the dev). Confirmed that
> the panic is fixed with this patch.
>
> Signed-off-by: Krishna Kumar <krkumar2@in.ibm.com>
I guess the virtio NET maintainers don't deserve to get CC:'d on a fix
like this? :-(
Michael Tsirkin is who maintains this driver actively and is the one
who will merge this kind of fix to me, therefore if you don't CC:
him it might not get integrated at all.
next prev parent reply other threads:[~2011-07-15 15:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-15 9:16 [PATCH] Fix panic in virtnet_remove Krishna Kumar
2011-07-15 15:19 ` David Miller [this message]
2011-07-16 5:32 ` Krishna Kumar2
2011-07-17 10:12 ` Michael S. Tsirkin
-- strict thread matches above, loose matches on Subject: below --
2011-07-18 3:57 Krishna Kumar
2011-07-18 13:03 ` Michael S. Tsirkin
2011-07-20 7:43 Krishna Kumar
2011-07-20 15:17 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110715.081909.1693878001743345571.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=krkumar2@in.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).