From: Jiri Pirko <jpirko@redhat.com>
To: "Sebastian Pöhn" <sebastian.belden@googlemail.com>
Cc: sandeep.kumar@freescale.com, netdev@vger.kernel.org,
"Sebastian Pöhn" <sebastian.poehn@belden.com>
Subject: Re: gianfar vlan
Date: Fri, 15 Jul 2011 11:16:02 +0200 [thread overview]
Message-ID: <20110715091600.GA2250@minipsycho.brq.redhat.com> (raw)
In-Reply-To: <1310716743.1789.9.camel@DENEC1DT0191>
Fri, Jul 15, 2011 at 09:59:03AM CEST, sebastian.belden@googlemail.com wrote:
>Hi Jirka!
>
>The rx queue filer table also needs the RCTRL_PRSDEP_INIT to be set. So I would suggest to add FILREN to RCTRL_REQ_PARSER.
>
>Further I guess the parser should only be enabled if it is necessary (because of VLAN, IP, TCP or FILREN acceleration modes).
>
>What about putting the
>
>if (tempval & RCTRL_REQ_PARSER)
> tempval |= RCTRL_PRSDEP_INIT;
>else
> tempval &= ~RCTRL_PRSDEP_INIT;
>
>in a dedicated routine and call it every time one of the four features is altered?
Ok why not. Would you please cook up the patch and post it? Thanks.
Jirka
>
>Greetings
>Sebastian
>
>> Hi Sandeep.
>>
>> I'm trying to remove gfar_vlan_rx_register() and move the vlan accel
>> enabling/disabling to gfar_set_features() -> startup_gfar() ->
>> gfar_init_mac(). I'm not sure how to handle following lines in
>> gfar_vlan_rx_register():
>>
>> /* If parse is no longer required, then disable parser */
>> if (tempval & RCTRL_REQ_PARSER)
>> tempval |= RCTRL_PRSDEP_INIT;
>> else
>> tempval &= ~RCTRL_PRSDEP_INIT;
>>
>> Should this be done only on disabling vlan accel (both rx an tx)?
>> Or can I just do that always in startup_gfar() ?
>>
>> Thanks.
>>
>> Jirka
>
next prev parent reply other threads:[~2011-07-15 9:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-15 7:59 gianfar vlan Sebastian Pöhn
2011-07-15 9:16 ` Jiri Pirko [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-07-14 13:14 Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110715091600.GA2250@minipsycho.brq.redhat.com \
--to=jpirko@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=sandeep.kumar@freescale.com \
--cc=sebastian.belden@googlemail.com \
--cc=sebastian.poehn@belden.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).