From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Lamparter Subject: Re: [PATCH] bridge: mask forwarding of IEEE 802 local multicast groups Date: Fri, 15 Jul 2011 18:33:45 +0200 Message-ID: <20110715163345.GD1407585@jupiter.n2.diac24.net> References: <20110711082755.0b38a15a@nehalam.ftrdhcpuser.net> <20110712113643.GC616804@jupiter.n2.diac24.net> <20110715160357.GC1407585@jupiter.n2.diac24.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Nick Carter , Stephen Hemminger , netdev@vger.kernel.org, =?utf-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= , davem@davemloft.net To: David Lamparter Return-path: Received: from spaceboyz.net ([87.106.131.203]:52176 "EHLO spaceboyz.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751163Ab1GOQdy (ORCPT ); Fri, 15 Jul 2011 12:33:54 -0400 Content-Disposition: inline In-Reply-To: <20110715160357.GC1407585@jupiter.n2.diac24.net> Sender: netdev-owner@vger.kernel.org List-ID: On Fri, Jul 15, 2011 at 06:03:57PM +0200, David Lamparter wrote: > On Fri, Jul 15, 2011 at 04:44:50PM +0100, Nick Carter wrote: > > On 12 July 2011 12:36, David Lamparter wrote: > > > On Mon, Jul 11, 2011 at 08:27:55AM -0700, Stephen Hemminger wrote: > > >> I am still undecided on this. Understand the need, but don't like idea > > >> of bridge behaving in non-conforming manner. Will see if IEEE 802 committee > > >> has any input. > > > > > > The patch doesn't make the bridge behave nonconformant. The default mask > > > is 0, which just keeps the old behaviour. P.S.: I'd like to once more stress this. In my opinion the patch should be merged because it provides desireable functionality at a small cost (one test, one knob) and __does not change any default behaviour__.