netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "jiangtao.jit" <jiangtao.jit@gmail.com>
To: "netdev" <netdev@vger.kernel.org>
Subject: problem with function vlan_get_protocol()
Date: Sun, 17 Jul 2011 12:53:15 +0800	[thread overview]
Message-ID: <201107171253127340006@gmail.com> (raw)

Hi,all

in file   inclue/linux/if_vlan.h

there is a statement in function vlan_get_protocol()

	if (likely(protop))
		protocol = *protop;

do we need an else branch on pointer protop failed ?  through the else is unlikely 

	if (likely(protop))
		protocol = *protop;
    else
		protocol = proto;

is it necessary ?

thanks


2011-07-17 
jiangtao.jit 


             reply	other threads:[~2011-07-17  4:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-17  4:53 jiangtao.jit [this message]
2011-07-17  7:34 ` problem with function vlan_get_protocol() Francois Romieu
2011-07-17  8:15 ` jiangtao.jit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201107171253127340006@gmail.com \
    --to=jiangtao.jit@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).