* [Patch] include/linux/sdla.h: remove the prototype of sdla()
@ 2011-07-17 8:22 Américo Wang
2011-07-18 18:06 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Américo Wang @ 2011-07-17 8:22 UTC (permalink / raw)
To: Michal Marek; +Cc: Andrew Morton, linux-kernel, Linux Kernel Network Developers
[-- Attachment #1: Type: text/plain, Size: 394 bytes --]
`make headers_check` complains that
linux-2.6/usr/include/linux/sdla.h:116: userspace cannot reference
function or variable defined in the kernel
this is due to that there is no such a kernel function,
void sdla(void *cfg_info, char *dev, struct frad_conf *conf, int quiet);
I don't know why we have it in a kernel header, so remove it.
Signed-off-by: WANG Cong <xiyou.wangcong@gmail.com>
[-- Attachment #2: include-linux-sdla_h-fix-headers-check-warning.diff --]
[-- Type: text/x-patch, Size: 408 bytes --]
diff --git a/include/linux/sdla.h b/include/linux/sdla.h
index 564acd3..9995c7f 100644
--- a/include/linux/sdla.h
+++ b/include/linux/sdla.h
@@ -112,11 +112,7 @@ struct sdla_dlci_conf {
short Tb_max;
};
-#ifndef __KERNEL__
-
-void sdla(void *cfg_info, char *dev, struct frad_conf *conf, int quiet);
-
-#else
+#ifdef __KERNEL__
/* important Z80 window addresses */
#define SDLA_CONTROL_WND 0xE000
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Patch] include/linux/sdla.h: remove the prototype of sdla()
2011-07-17 8:22 [Patch] include/linux/sdla.h: remove the prototype of sdla() Américo Wang
@ 2011-07-18 18:06 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2011-07-18 18:06 UTC (permalink / raw)
To: xiyou.wangcong; +Cc: mmarek, akpm, linux-kernel, netdev
From: Américo Wang <xiyou.wangcong@gmail.com>
Date: Sun, 17 Jul 2011 16:22:20 +0800
> `make headers_check` complains that
>
> linux-2.6/usr/include/linux/sdla.h:116: userspace cannot reference
> function or variable defined in the kernel
>
> this is due to that there is no such a kernel function,
>
> void sdla(void *cfg_info, char *dev, struct frad_conf *conf, int quiet);
>
> I don't know why we have it in a kernel header, so remove it.
>
> Signed-off-by: WANG Cong <xiyou.wangcong@gmail.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-07-18 18:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-07-17 8:22 [Patch] include/linux/sdla.h: remove the prototype of sdla() Américo Wang
2011-07-18 18:06 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).