From: "Michael S. Tsirkin" <mst@redhat.com>
To: Jesper Juhl <jj@chaosbits.net>
Cc: kvm@vger.kernel.org, virtualization@lists.linux-foundation.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCHv9] vhost: experimental tx zero-copy support
Date: Mon, 18 Jul 2011 10:16:06 +0300 [thread overview]
Message-ID: <20110718071606.GA29538@redhat.com> (raw)
In-Reply-To: <alpine.LNX.2.00.1107172153030.32359@swampdragon.chaosbits.net>
On Sun, Jul 17, 2011 at 10:01:41PM +0200, Jesper Juhl wrote:
> > @@ -28,10 +29,18 @@
> >
> > #include "vhost.h"
> >
> > +static int zcopytx;
> > +module_param(zcopytx, int, 0444);
>
> Should everyone be able to read this? How about "0440" just to be
> paranoid? or?
I find it very helpful to have the parameter visible in sysfs.
Given that:
[mst@tuck linux-2.6]$ grep module_param drivers/net/*c|grep [64]44|wc -l
14
[mst@tuck linux-2.6]$ grep module_param drivers/net/*c|grep [64]40|wc -l
0
[mst@tuck linux-2.6]$ grep module_param drivers/net/*c|grep [64]00|wc -l
7
So at least the precedent is against 0440. What do you think?
--
MST
prev parent reply other threads:[~2011-07-18 7:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-17 19:36 [PATCHv9] vhost: experimental tx zero-copy support Michael S. Tsirkin
2011-07-17 19:53 ` David Miller
2011-07-17 20:01 ` Jesper Juhl
2011-07-18 7:16 ` Michael S. Tsirkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110718071606.GA29538@redhat.com \
--to=mst@redhat.com \
--cc=jj@chaosbits.net \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).