From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: netdev@vger.kernel.org
Subject: Re: [BUG] ipv6: all routes share same inetpeer
Date: Tue, 19 Jul 2011 11:59:29 -0700 (PDT) [thread overview]
Message-ID: <20110719.115929.106510307852361614.davem@davemloft.net> (raw)
In-Reply-To: <1311101870.3113.6.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Tue, 19 Jul 2011 20:57:50 +0200
> Le mardi 19 juillet 2011 à 20:20 +0200, Eric Dumazet a écrit :
>> Le mardi 19 juillet 2011 à 10:37 -0700, David Miller a écrit :
>> > From: Eric Dumazet <eric.dumazet@gmail.com>
>> > Date: Tue, 19 Jul 2011 19:23:49 +0200
>> >
>> > > Maybe you can find the bug before me ?
>> >
>> > I think when we add the route we cow the metrics almost immediately.
>> > The daddr is, unfortunately, fully prefixed at that point.
>>
>> Yes, we shall provide a second ip6_rt_copy() argument, with the
>> destination address.
>>
>
> Hmm, or maybe just change the dst_copy_metrics(&rt->dst, &ort->dst);
> call done from ip6_rt_copy(), to avoid doing the COW if not really
> needed ?
This is ok if it handles the case where ort's metrics point to
writable inetpeer memory.
next prev parent reply other threads:[~2011-07-19 18:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-19 17:23 [BUG] ipv6: all routes share same inetpeer Eric Dumazet
2011-07-19 17:37 ` David Miller
2011-07-19 18:20 ` Eric Dumazet
2011-07-19 18:57 ` Eric Dumazet
2011-07-19 18:59 ` David Miller [this message]
2011-07-20 5:29 ` Eric Dumazet
2011-07-20 6:18 ` Eric Dumazet
2011-07-22 4:25 ` David Miller
2011-07-22 0:18 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110719.115929.106510307852361614.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).