From: Stephen Hemminger <shemminger@vyatta.com>
To: Krishna Kumar <krkumar2@in.ibm.com>
Cc: mst@redhat.com, netdev@vger.kernel.org, davem@davemloft.net
Subject: Re: [PATCH] Fix panic in virtnet_remove
Date: Wed, 20 Jul 2011 08:17:33 -0700 [thread overview]
Message-ID: <20110720081733.5afa3f8c@nehalam.ftrdhcpuser.net> (raw)
In-Reply-To: <20110720074339.7842.72593.sendpatchset@krkumar2.in.ibm.com>
On Wed, 20 Jul 2011 13:13:39 +0530
Krishna Kumar <krkumar2@in.ibm.com> wrote:
> Fix a panic in virtnet_remove. unregister_netdev has already
> freed up the netdev (and virtnet_info) due to dev->destructor
> being set, while virtnet_info is still required. Remove
> virtnet_free altogether, and move the freeing of the per-cpu
> statistics from virtnet_free to virtnet_remove.
>
> Tested patch below.
>
> Signed-off-by: Krishna Kumar <krkumar2@in.ibm.com>
Need to check veth and xen for same problem.
Acked-by: Stephen Hemminger <shemminger@vyatta.com>
next prev parent reply other threads:[~2011-07-20 15:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-20 7:43 [PATCH] Fix panic in virtnet_remove Krishna Kumar
2011-07-20 15:17 ` Stephen Hemminger [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-07-18 3:57 Krishna Kumar
2011-07-18 13:03 ` Michael S. Tsirkin
2011-07-15 9:16 Krishna Kumar
2011-07-15 15:19 ` David Miller
2011-07-16 5:32 ` Krishna Kumar2
2011-07-17 10:12 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110720081733.5afa3f8c@nehalam.ftrdhcpuser.net \
--to=shemminger@vyatta.com \
--cc=davem@davemloft.net \
--cc=krkumar2@in.ibm.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).