public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Stephen Hemminger <shemminger@vyatta.com>
To: Denys Fedoryshchenko <denys@visp.net.lb>
Cc: <netdev@vger.kernel.org>
Subject: Re: [RFC] iproute2, ifindex option
Date: Wed, 20 Jul 2011 08:37:53 -0700	[thread overview]
Message-ID: <20110720083753.2b8de970@nehalam.ftrdhcpuser.net> (raw)
In-Reply-To: <f91760b4ff170e4bdbd46f40822dd95e@visp.net.lb>

On Mon, 18 Jul 2011 11:38:33 +0300
Denys Fedoryshchenko <denys@visp.net.lb> wrote:

>  After battling with iproute2 interface name caching, i decided to try 
>  to introduce ifindex option, where i can specify manually device index, 
>  and avoid expensive device index lookups, especially during massive 
>  changes for qdisc/class.
>  In batch mode ll_map cache will cause problems on servers with ppp 
>  interfaces (same name after while can have another index), and also if i 
>  run command too often, each start it will retrieve list of all 
>  interfaces, on 3k+ interfaces it will be CPU hog.
> 
>  This is sample of patch, just for qdisc/class/filter modify and show 
>  operation.
> 
>  Here is some changes in logic, because before qdisc code during _list 
>  operation was not checking duplicate "dev" argument, as it done in 
>  _modify code and class/filter list code.
> 
>  Also maybe i need to change duparg to something else? Because:
>  centaur iproute2-newifindex # tc/tc -s -d filter show ifindex 23 dev 
>  sdf
>  Error: duplicate "ifindex": "sdf" is the second value.
>  Or it is ok like this?
> 
>  I'm sorry that patch is not inline, seems my webmail can't do it now, i 
>  will try to install normal mail client.

If caching is a problem, I would rather just get rid of the cache altogether.
There are a number of other places where it is a problem as well.

  reply	other threads:[~2011-07-20 15:37 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-18  8:38 [RFC] iproute2, ifindex option Denys Fedoryshchenko
2011-07-20 15:37 ` Stephen Hemminger [this message]
2011-07-20 15:54   ` Denys Fedoryshchenko
2011-07-20 15:58     ` Stephen Hemminger
2011-07-20 16:12       ` Denys Fedoryshchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110720083753.2b8de970@nehalam.ftrdhcpuser.net \
    --to=shemminger@vyatta.com \
    --cc=denys@visp.net.lb \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox