Re: [patch net-next-2.6 37/47] igb: do vlan cleanup

[Jiri Pirko <jpirko@redhat.com>]

Wed, Jul 20, 2011 at 07:35:33PM CEST, jesse@nicira.com wrote:
>On Wed, Jul 20, 2011 at 7:54 AM, Jiri Pirko <jpirko@redhat.com> wrote:
>> @@ -2943,7 +2944,7 @@ static void igb_rlpml_set(struct igb_adapter *adapter)
>>        struct e1000_hw *hw = &adapter->hw;
>>        u16 pf_id = adapter->vfs_allocated_count;
>>
>> -       if (adapter->vlgrp)
>> +       if (igb_vlan_used(adapter))
>>                max_frame_size += VLAN_TAG_SIZE;
>
>There are similar issues here as with the VF driver.  I think you're
>also confusing vlan acceleration with vlan filtering.  If no vlan
>filters are in use but the card is in promiscuous mode, the buffer
>will be undersized and we lose tagged packets.

I'm certainly not confusing vlan accel and filtering. Here is the
intension is the behaviour remains intact as well. I believe it's true.

>
>> +static void igb_vlan_mode(struct net_device *netdev, bool vlan_on)
>>  {
>>        struct igb_adapter *adapter = netdev_priv(netdev);
>>        struct e1000_hw *hw = &adapter->hw;
>>        u32 ctrl, rctl;
>>
>>        igb_irq_disable(adapter);
>> -       adapter->vlgrp = grp;
>>
>> -       if (grp) {
>> +       if (vlan_on) {
>>                /* enable VLAN tag insert/strip */
>
>This should be controlled by ethtool, not by whether vlan filters are
>enabled.  Essentially, with this, you are recreating the logic of the
>old vlan model in the new one.

------------------------------------------------------------------------------
10 Tips for Better Web Security
Learn 10 ways to better secure your business today. Topics covered include:
Web security, SSL, hacker attacks & Denial of Service (DoS), private keys,
security Microsoft Exchange, secure Instant Messaging, and much more.
http://www.accelacomm.com/jaw/sfnl/114/51426210/
_______________________________________________
E1000-devel mailing list
E1000-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/e1000-devel
To learn more about Intel&#174; Ethernet, visit http://communities.intel.com/community/wired