From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: fernando@gont.com.ar, security@kernel.org, eugeneteo@kernel.sg,
netdev@vger.kernel.org, mpm@selenic.com
Subject: Re: [PATCH net-next-2.6] ipv6: make fragment identifications less predictable
Date: Thu, 21 Jul 2011 21:26:16 -0700 (PDT) [thread overview]
Message-ID: <20110721.212616.1138861523109414324.davem@davemloft.net> (raw)
In-Reply-To: <1311108423.3113.24.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Tue, 19 Jul 2011 22:47:03 +0200
> IPv6 fragment identification generation is way beyond what we use for
> IPv4 : It uses a single generator. Its not scalable and allows DOS
> attacks.
>
> Now inetpeer is IPv6 aware, we can use it to provide a more secure and
> scalable frag ident generator (per destination, instead of system wide)
>
> This patch :
> 1) defines a new secure_ipv6_id() helper
> 2) extends inet_getid() to provide 32bit results
> 3) extends ipv6_select_ident() with a new dest parameter
>
> Reported-by: Fernando Gont <fernando@gont.com.ar>
> CC: Matt Mackall <mpm@selenic.com>
> CC: Eugene Teo <eugeneteo@kernel.sg>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Applied, and I'll queue up your backport-friendly version for -stable.
prev parent reply other threads:[~2011-07-22 4:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4E24BE94.7010301@gont.com.ar>
[not found] ` <1311082696.2375.26.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC>
[not found] ` <1311089463.2375.42.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC>
2011-07-19 20:47 ` [PATCH net-next-2.6] ipv6: make fragment identifications less predictable Eric Dumazet
2011-07-19 20:56 ` Matt Mackall
2011-07-20 6:50 ` Eric Dumazet
2011-07-20 8:25 ` Eric Dumazet
2011-07-20 10:27 ` Eric Dumazet
2011-07-21 1:32 ` Fernando Gont
2011-07-21 22:17 ` David Miller
2011-07-21 22:46 ` Rick Jones
2011-07-21 23:13 ` David Miller
2011-07-21 23:37 ` Fernando Gont
2011-07-22 0:07 ` David Miller
2011-07-22 0:34 ` Rick Jones
2011-07-22 1:18 ` Fernando Gont
2011-07-22 4:26 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110721.212616.1138861523109414324.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=eugeneteo@kernel.sg \
--cc=fernando@gont.com.ar \
--cc=mpm@selenic.com \
--cc=netdev@vger.kernel.org \
--cc=security@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).