From: David Miller <davem@davemloft.net>
To: mst@redhat.com
Cc: krkumar2@in.ibm.com, rusty@rustcorp.com.au,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org, shemminger@vyatta.com
Subject: Re: [PATCH repost] Fix panic in virtnet_remove
Date: Thu, 21 Jul 2011 21:29:50 -0700 (PDT) [thread overview]
Message-ID: <20110721.212950.1991725607632413241.davem@davemloft.net> (raw)
In-Reply-To: <20110720143115.GB6787@redhat.com>
From: "Michael S. Tsirkin" <mst@redhat.com>
Date: Wed, 20 Jul 2011 17:31:15 +0300
> On Wed, Jul 20, 2011 at 07:26:02PM +0530, Krishna Kumar wrote:
>> Fix a panic in virtnet_remove. unregister_netdev has already
>> freed up the netdev (and virtnet_info) due to dev->destructor
>> being set, while virtnet_info is still required. Remove
>> virtnet_free altogether, and move the freeing of the per-cpu
>> statistics from virtnet_free to virtnet_remove.
>>
>> Tested patch below.
>>
>> Signed-off-by: Krishna Kumar <krkumar2@in.ibm.com>
>
> Also note that the crash was apparently introduced by
> 3fa2a1df909482cc234524906e4bd30dee3514df in net-next,
> so this is a net-next only patch.
>
> Stephen, was there any special reason to free the memory
> in the destructor like you did?
>
> Acked-by: Michael S. Tsirkin <mst@redhat.com>
Applied.
prev parent reply other threads:[~2011-07-22 4:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-20 13:56 [PATCH repost] Fix panic in virtnet_remove Krishna Kumar
2011-07-20 14:31 ` Michael S. Tsirkin
2011-07-22 4:29 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110721.212950.1991725607632413241.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=krkumar2@in.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=shemminger@vyatta.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).