From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH 08/13] net: convert drivers to paged frag API. Date: Fri, 22 Jul 2011 07:12:17 -0700 (PDT) Message-ID: <20110722.071217.607687554920673786.davem@davemloft.net> References: <1311340095.12772.57.camel@zakaz.uk.xensource.com> <1311340653-19336-8-git-send-email-ian.campbell@citrix.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: ian.campbell-Sxgqhf6Nn4DQT0dZR+AlfA@public.gmane.org Return-path: In-Reply-To: <1311340653-19336-8-git-send-email-ian.campbell-Sxgqhf6Nn4DQT0dZR+AlfA@public.gmane.org> Sender: linux-nfs-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: netdev.vger.kernel.org From: Ian Campbell Date: Fri, 22 Jul 2011 14:17:28 +0100 > - put_dma(tx->index,eni_dev->dma,&j,(unsigned long) > - skb_shinfo(skb)->frags[i].page + skb_shinfo(skb)->frags[i].page_offset, > + put_dma(tx->index,eni_dev->dma,&j, > + (unsigned long)skb_frag_address(&skb_shinfo(skb)->frags[i]), This is not an equivalent transformation. skb_frag_address() does a page_address() on the frag page, but that is not what the code was doing here previously. It's possible the code was buggy, but you can't do a fix like that amidst what is supposed to be a semantically NOP transformation. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html