From: "Guo-Fu Tseng" <cooldavid@cooldavid.org>
To: "Michał Mirosław " <mirqus@gmail.com>
Cc: Jason Lamb <jason@lambhome.org>,
linux-netdev <netdev@vger.kernel.org>,
Jason Long <jason@octgsoftware.com>,
stable@kernel.org, Marcus Becker <marcus.disi@gmail.com>,
Aries Lee <arieslee@jmicron.com>,
Devinchiu <devinchiu@jmicron.com>,
Marc Schiffbauer <mschiff@gentoo.org>,
David Miller <davem@davemloft.net>
Subject: Re: [PATCH net-2.6] jme: Fix unmap error (Causing system freeze)
Date: Fri, 22 Jul 2011 16:49:43 +0800 [thread overview]
Message-ID: <20110722083637.M71863@cooldavid.org> (raw)
In-Reply-To: <CAHXqBF+1aJ0O9WxrZTKfYMm57emysfPUnA-=M9DZN5kUGnhW8g@mail.gmail.com>
On Fri, 22 Jul 2011 09:45:42 +0200, Michał Mirosław wrote
> 2011/7/21 <cooldavid@cooldavid.org>:
> > From: Guo-Fu Tseng <cooldavid@cooldavid.org>
> >
> > This patch add the missing dma_unmap().
> > Which solved the critical issue of system freeze on heavy load.
> >
> > Michal Miroslaw's rejected patch:
> > [PATCH v2 10/46] net: jme: convert to generic DMA API
> > Pointed out the issue also, thank you Michal.
> > But the fix was incorrect. It would unmap needed address
> > when low memory.
>
> My patch also fixed another issue - from correctness point of view,
> you should not use virt_to_page+dma_map_page here, but dma_map_single.
>
> Best Regards,
> Michał Mirosław
Hi Michał:
Yes, I did noticed that. :)
And I agreed that using {dma|pci}_map_single is better than
calling virt_to_page in driver.
It's just that I'm not sure if it is really preferred to use
dma_map_single over pci_map_single for PCI device driver?
You are very welcome to send another patch for converting the
DMA API using.
Guo-Fu Tseng
_______________________________________________
stable mailing list
stable@linux.kernel.org
http://linux.kernel.org/mailman/listinfo/stable
prev parent reply other threads:[~2011-07-22 8:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-21 2:57 [PATCH net-2.6] jme: Fix unmap error (Causing system freeze) cooldavid
2011-07-21 19:30 ` Chris Wright
2011-07-21 22:23 ` David Miller
2011-07-22 7:45 ` Michał Mirosław
2011-07-22 8:49 ` Guo-Fu Tseng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110722083637.M71863@cooldavid.org \
--to=cooldavid@cooldavid.org \
--cc=arieslee@jmicron.com \
--cc=davem@davemloft.net \
--cc=devinchiu@jmicron.com \
--cc=jason@lambhome.org \
--cc=jason@octgsoftware.com \
--cc=marcus.disi@gmail.com \
--cc=mirqus@gmail.com \
--cc=mschiff@gentoo.org \
--cc=netdev@vger.kernel.org \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).